🐛 fix(check): use open records for dict literals and improve dead code detection#1677
Merged
Merged
Conversation
harehare
commented
May 2, 2026
harehare
commented
Owner
- Dict literals with all-string keys now use a fresh row variable instead of RowEmpty, allowing dicts with different optional fields to be unified without spurious type mismatches (e.g. arrays of state dicts where some entries omit a field like "n")
- resolve_record_field_accesses now follows row variable chains recursively to find fields added via unification, while still reporting UndefinedField when the row chain ends with no matching field
- detect_dead_then_branch skips Variables initialized from non-literal expressions (calls, field accesses, etc.) since their runtime type may differ from the statically inferred type
…e detection - Dict literals with all-string keys now use a fresh row variable instead of RowEmpty, allowing dicts with different optional fields to be unified without spurious type mismatches (e.g. arrays of state dicts where some entries omit a field like "n") - resolve_record_field_accesses now follows row variable chains recursively to find fields added via unification, while still reporting UndefinedField when the row chain ends with no matching field - detect_dead_then_branch skips Variables initialized from non-literal expressions (calls, field accesses, etc.) since their runtime type may differ from the statically inferred type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.