✨ feat(mq-check): match patterns against markdown node kinds#1958
Merged
Conversation
Extend `match` type patterns so an arm like `:h1` or `:code` matches a markdown value against a node-kind selector (same names as selectors, without the leading `.`), in addition to the existing type names (`:string`, `:number`, etc.). Attribute selectors (e.g. `:lang`) are rejected since they don't identify a node kind. Also fix match guard/body evaluation to run against the matched value instead of the pipeline's `.`, so attribute selectors like `.depth` or `.lang` resolve correctly inside a guard or arm body without binding a variable first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
matchtype patterns so an arm like:h1or:codematches a markdown value against a node-kind selector (same names as selectors, without the leading.), in addition to the existing type names (:string,:number, etc.). Attribute selectors (e.g.:lang) are rejected since they don't identify a node kind.Also fix match guard/body evaluation to run against the matched value instead of the pipeline's
., so attribute selectors like.depthor.langresolve correctly inside a guard or arm body without binding a variable first.Close #1946