✨ feat(mq-lsp): add signature help support#2012
Merged
Merged
Conversation
Implement the textDocument/signatureHelp handler so the client gets inline argument-position hints while typing a function or macro call. mq_hir::Symbol ranges are too coarse for this (a Call symbol's range covers only its name token, and punctuation isn't lowered into HIR at all), so signature_help.rs re-parses the document into a CST and walks it directly to find the enclosing call, its parens, and its commas, then resolves the callee's Params through the existing Hir lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the textDocument/signatureHelp handler so the client gets inline argument-position hints while typing a function or macro call.
mq_hir::Symbol ranges are too coarse for this (a Call symbol's range covers only its name token, and punctuation isn't lowered into HIR at all), so signature_help.rs re-parses the document into a CST and walks it directly to find the enclosing call, its parens, and its commas, then resolves the callee's Params through the existing Hir lookup.
Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context