✨ feat(mq-lang): add depth parameter to section::sections - #2208
Merged
Conversation
sections() previously only supported flat boundaries (every heading of any level ends the previous section), so nested subsection content was unreachable in bulk without calling section() once per known heading name. Add a depth parameter reusing the same same-or-higher-level boundary algorithm section() already had, and simplify section() to delegate to sections(md_nodes, depth) | title_contains(pattern). split() is intentionally left untouched: reusing the new nested logic there would drop content from the documented split-document-by-heading cookbook example.
Replace the ad-hoc single-case depth tests with @parametrize cases covering both depth=false and depth=true, matching the file's existing table-driven style. Also adds a flat-mode negative check (subheading text must NOT leak into a flat section's body) that the previous depth=true-only tests didn't cover.
Avoid recomputing len(start_indices) on every while-loop iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sections() previously only supported flat boundaries (every heading of any level ends the previous section), so nested subsection content was unreachable in bulk without calling section() once per known heading name. Add a depth parameter reusing the same same-or-higher-level boundary algorithm section() already had, and simplify section() to delegate to sections(md_nodes, depth) | title_contains(pattern).
Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context