Skip to content

Deferred dep migrations: TypeScript 7 and Vitest 4 #228

Description

@jack-champagne

Held back from #227 because each needs real work, not a version bump. Both were bisected against a verified-green baseline (apply one bump, reinstall, typecheck).

typescript ^5.6.0 → ^7.0.2 — 195 typecheck errors

TS 7 no longer auto-includes @types/node, so every Node global fails:

../amico-run/src/estimate.ts(24,26):  error TS2591: Cannot find name 'node:os'.
../amico-run/src/estimate.ts(113,36): error TS2503: Cannot find namespace 'NodeJS'.
../amico-run/src/estimate.ts(113,56): error TS2591: Cannot find name 'process'.

Fix is to declare types in the tsconfigs ("types": ["node"], plus ["vscode"] where relevant) rather than relying on the old implicit inclusion. Mechanical but wide, and worth reviewing on its own.

vitest ^2.1.0 → ^4.1.10 — 4 typecheck errors

vitest 4 peers vite@^6 || ^7 || ^8; the workspace resolves vite 5.4.21:

✕ unmet peer vite@"^6.0.0 || ^7.0.0 || ^8.0.0": found 5.4.21
vitest/dist/chunks/evaluatedModules.d.ts(1,34): error TS2307: Cannot find module 'vite/module-runner'

vite/module-runner exists from vite 6. Dependabot cannot see thisvite is not a direct dependency, it only arrives as a vitest peer, so it is not in any group dependabot manages. Needs vite added as an explicit devDependency at ^6+, or vitest held.

Also worth deciding separately

@types/vscode ^1.95.0 → ^1.125.0 is held in #227 because vsce refuses to package when the types outrun engines.vscode:

@types/vscode ^1.125.0 greater than engines.vscode ^1.95.0.
Either upgrade engines.vscode or use an older @types/vscode version

Raising engines.vscode raises the minimum VS Code version users need. That is a product call, not a dependency chore — hence held.

Worth noting local vsce package accepted the mismatch while CI's rejected it, so the local toolchain will not reliably catch this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions