fix(extension): strip webview zoom bridge and diag lanes (amicode#266) - #321
Open
gennadiryan wants to merge 7 commits into
Open
fix(extension): strip webview zoom bridge and diag lanes (amicode#266)#321gennadiryan wants to merge 7 commits into
gennadiryan wants to merge 7 commits into
Conversation
added 6 commits
August 9, 2026 01:25
…ure failure; modified to be eager so that an empty log is genuinely attributable to a failure of the chord to land in the webview
gennadiryan
marked this pull request as ready for review
August 9, 2026 22:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
amicode#266 — Cmd/Ctrl
+/-/0zoom keybindings did nothing while focus was inside the chat webview. The fix moves zoom handling out of the extension entirely: the vendored fork now captures the chords in each app document and applies its in-app CSS zoom (companion PR in harmoniqs/opencode).This PR removes the extension-side machinery built for the previous capture-and-forward approach:
chat_bridge.ts— deleted thezoomlane, thediag-loglane, the eager "Amicode — webview diag" output channel and its activation probe.chat_panel.ts— deleted the host-page keydown listener and thezoom/diag-logallowlist entries.__mocks__/vscode.ts— removed the zoom/diag test blocks and theoutputLineschannel mock.Why the previous approach could not work: keydowns inside the app iframe never reach the workbench keybinding service (cross-origin, frame-local event routing), so no extension-side capture point existed for panel focus; with the webview tab focused, host-page capture double-fired alongside the workbench's own native zoom (
preventDefaultcannot suppress the webview's keydown forwarding).Verification
amico/~/.amico);tsc --noEmitclean.References #266.