docs(m2): app-extraction inventory + manifest stamps (M4 complete) #480
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # M2 app-bundle extraction inventory | ||
|
|
||
| Program of record: [harmoniqs/amicode#451](https://github.com/harmoniqs/amicode/issues/451) · | ||
| migration manifest: `docs/migration-canonical-opencode.md`. | ||
|
|
||
| Baseline diff: **upstream `v1.18.10` → shipped pin `v1.18.10-amicode.11`** (the vendored | ||
| binary's app surface), packages `app` / `ui` / `session-ui`: | ||
|
|
||
| **411 files, +40,526 / −2,249 — 235 added · 172 modified · 4 deleted.** | ||
|
|
||
| Generated 2026-08-20 (`git diff --name-status v1.18.10 v1.18.10-amicode.11` in | ||
| the fork; upstream tag fetched from `anomalyco/opencode`). | ||
|
|
||
| ## Bucket A — added files (235): move as-is | ||
|
|
||
| | Where | Count | Notes | | ||
| |---|---|---| | ||
| | `packages/ui/src/amicode/**` | 108 | The pure-additive Amicode component library — the natural first slice | | ||
| | `packages/app/src/components/**` | 27 | App-side components (vault-browser, split-frame, status-popover-body, settings-v2/permissions, …) | | ||
| | `packages/app/src/pages/**` | 18 | Amicode pages + timeline ports | | ||
| | `packages/app/src/utils/**` | 19 | global-clipboard (+tests), amicode utils | | ||
| | `packages/session-ui/src/components/**` | 7 | message-part groups + skill parts | | ||
| | `packages/app/src/context/**` | 4 | app context additions | | ||
| | `packages/app/e2e/regression/**` | 6 | regression specs (the ported e2e suite's seed) | | ||
| | `packages/app/docs/adr/**` | 4 | the fork's ADRs — move to the amicode repo's docs | | ||
| | assets / types / misc | 8 | | | ||
|
|
||
| Strategy: these move into the amicode repo's app bundle unchanged. Their | ||
| imports reference sibling upstream modules — that coupling is what the bundle's | ||
| peer-dep on `@opencode-ai/*` packages resolves at build time. | ||
|
Comment on lines
+28
to
+30
There was a problem hiding this comment. 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -e
printf '%s\n' '--- inventory file ---'
sed -n '1,100p' docs/m2-app-extraction-inventory.md
printf '%s\n' '--- canonical migration references ---'
sed -n '70,105p' docs/migration-canonical-opencode.md
printf '%s\n' '--- related terms and import-adaptation references ---'
rg -n -C 3 'Bucket A|unchanged|verbatim|import adaptation|import adapt|packages/ui/src/amicode|`@opencode-ai/sdk`' docsRepository: harmoniqs/amicode Length of output: 19479 🏁 Script executed: #!/bin/bash
set -e
python3 - <<'PY'
from pathlib import Path
inventory = Path("docs/m2-app-extraction-inventory.md").read_text()
migration = Path("docs/migration-canonical-opencode.md").read_text()
inventory_claim = "move into the amicode repo's app bundle unchanged"
verbatim_claim = "holding bucket A verbatim"
adaptation_claim = "adapt imports to canonical's public client SDK (`@opencode-ai/sdk`)"
for label, text, claim in (
("inventory", inventory, inventory_claim),
("inventory", inventory, verbatim_claim),
("migration", migration, adaptation_claim),
):
print(f"{label}: {claim!r}: {claim in text}")
print("same Bucket A scope markers:", "Bucket A" in inventory and "packages/ui/src/amicode/*" in migration)
PY
printf '%s\n' '--- imports in the documented UI extraction slice ---'
rg -n '^(import|export).*(`@opencode-ai/`|from [".])' packages/ui/src/amicode 2>/dev/null | head -80 || true
printf '%s\n' '--- SDK import patterns elsewhere ---'
rg -n -g '*.ts' -g '*.tsx' '(`@opencode-ai/sdk`|from .*sdk)' packages 2>/dev/null | head -80 || trueRepository: harmoniqs/amicode Length of output: 482 Define the import adaptation step. Bucket A is described as moving “unchanged” and “verbatim,” but 🤖 Prompt for AI Agents |
||
|
|
||
| ## Bucket M — modified upstream files (172): the overlay pressure points | ||
|
|
||
| The 16 largest (the rest are small-name/import-level touches): | ||
|
|
||
| | File | Delta | Nature | | ||
| |---|---|---| | ||
| | `app/src/pages/home.tsx` | +2,233/−39 | the Amicode home (widget grid) grafted onto upstream's home | | ||
| | `app/src/components/session/session-header.tsx` | +671/−34 | header chrome + entity-rail dispatch | | ||
| | `session-ui/src/components/message-part.tsx` | +651/−210 | part rendering (ask cards, skill parts) | | ||
| | `app/src/pages/session/timeline/message-timeline.tsx` | +385/−23 | entity rail + AmicoSpinner mounts | | ||
| | `app/src/components/status-popover-body.tsx` | +351/−6 | solver-mode toggle + connections state | | ||
| | `app/src/components/session/session-context-tab.tsx` | +271/−3 | context tab (vault tree) | | ||
| | `app/src/utils/global-clipboard.test.ts` | +698/−0 | tests for the added clipboard util | | ||
| | `app/src/pages/session/composer/session-bug-dock.tsx` | +492/−0 | bug dock (file is added upstream-empty; content ours) | | ||
| | `app/src/components/amicode-defaults-capsule.tsx` | +475/−0 | ditto | | ||
| | `app/src/components/session/session-preview-tab.tsx` | +428/−0 | ditto | | ||
| | `app/src/components/split-frame.tsx` | +412/−0 | ditto | | ||
|
Comment on lines
+34
to
+48
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Correct the “16 largest” table count. The table contains 11 file rows, not 16. Add the five omitted files or change the heading to match the listed entries. 🤖 Prompt for AI Agents |
||
|
|
||
| A large fraction of "M" is upstream files that EXIST but whose content is | ||
| substantially ours (the +N/−0 shape) — effectively bucket-A files living at | ||
| upstream paths. The true behavioral overlays (home, session-header, | ||
| message-part, timeline, status-popover) are the files needing a compose/re-export | ||
| strategy: the bundle re-exports the upstream module with Amicode extensions | ||
| applied, rather than forking the file wholesale. | ||
|
|
||
| ## Bucket D — deleted (4): re-delete at build | ||
|
|
||
| `debug-bar.tsx` (deliberate fork deletion, per AMICODE-PATCHES policy), | ||
| `link.tsx`, `notification-click.ts` (+test). The bundle's build applies these | ||
| deletions over the pinned upstream tree. | ||
|
|
||
| ## i18n | ||
|
|
||
| The 72 amicode-era English keys (filled into 17 locales as EN fallbacks — | ||
| AMICODE-PATCHES 2026-08-01) live in the `language.tsx` modifications. They move | ||
| into the bundle's own locale tables, ending the upstream parity-test coupling. | ||
|
|
||
| ## Overlay architecture (the decision this inventory implies) | ||
|
|
||
| 1. The amicode repo gains `packages/app-bundle/` holding bucket A verbatim + | ||
| overlay modules for the true-M files + the i18n tables + bucket-D deletions. | ||
| 2. A pinned upstream checkout (canonical release tag, from | ||
| `anomalyco/opencode`) provides the base; the bundle builds against it via | ||
| the workspace's package graph (`@opencode-ai/ui`, `@opencode-ai/app` | ||
| internals as peer deps). | ||
| 3. CI pins the bundle to a canonical release (the same pin the updater | ||
| manages) and fails on API drift — the recurring post-cutover cost, made | ||
| loud at build time instead of silent at runtime. | ||
| 4. Extraction order (each slice independently shippable): | ||
| a. `ui/src/amicode/**` (108 files, zero upstream-file edits) | ||
| b. app components with the +N/−0 shape (effectively additive) | ||
| c. the true overlays (home, session-header, message-part, timeline, | ||
| status-popover) — the files where compose-vs-fork judgment is needed | ||
| d. i18n tables + deletions + e2e port | ||
|
|
||
| ## Honest scoping note (2026-08-20, night session) | ||
|
|
||
| This inventory is the M2 INPUT, not the extraction. The 411-file move is the | ||
| plan's declared long pole; the slices above are estimable now that the buckets | ||
| are counted. What is NOT done tonight: the bundle itself, its build, the | ||
| consumer flip (deck panes pointing at the service origin), and the CSP/origin | ||
| wiring — all tracked as the remaining M2 scope. M3 (cutover + ≥7-day dogfood | ||
| soak) and M5 (the one-push release) are gated on M2 by design. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Reconcile the Bucket A file count.
The listed counts sum to 201, but the bucket is declared as 235 files. This leaves 34 added files unaccounted for. Add the missing categories or correct the total before using this document as the extraction plan.
🤖 Prompt for AI Agents