fix(app): suppress per-message Changed files section - #734
Merged
Conversation
Remove the per-message "N Changed files" collapsible from both the v2 timeline (DiffSummary row in rows.ts) and the v1 session turn (session-turn-diffs block in session-turn.tsx). The section is redundant with the side-panel Files Changed tab and, more critically, its data source (summary.ts:computeDiff) returns an unfiltered snapshot diff that leaks cross-session file changes when sessions run concurrently — the snapshot system uses one shadow git repo per project, not per session. The rendering components, CSS, and i18n keys are left in place as dead code for easy reversal. The server-side summary.diffs computation is untouched; a follow-up in the fork will add agent-file filtering to computeDiff to fix the leak at the source (which also fixes the side-panel Fallback 1 path that aggregates per-message summary.diffs). Closes #733
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the per-message Changed files accordion from the chat timeline. The side-panel Files Changed tab is the canonical diff surface — the inline one was redundant and noisy.
Changes
rows.ts: removechangedFilesrow type from the timeline row builder (14 lines simplified)session-turn.tsx: strip theChangedFilesSectioncomponent and its rendering branch (~100 lines removed)rows-current.test.ts: add tests confirming changed-files rows are no longer emittedCloses #733