feat: theme-calculated Harmoniqs yellow — OKLCH-solved brand accent - #86
Closed
kateebonner wants to merge 1 commit into
Closed
feat: theme-calculated Harmoniqs yellow — OKLCH-solved brand accent#86kateebonner wants to merge 1 commit into
kateebonner wants to merge 1 commit into
Conversation
…brand-wide) brand_accent.ts computes the deployed accent from the active theme at webview boot: the canonical #FFF676 ships EXACTLY wherever contrast vs the theme's editor background clears 3:1 (all dark themes); light themes get the closest-to-brand gold by binary-searching lightness with hue + chroma held (gamut-clamped). Two tokens with different jobs: lines (--color-accent, contrast-solved: borders/rings/marks) and fills (--color-accent-fill, always the brand lemon — black text on it ≈ 19:1; a 3:1-darkened gold passes WCAG math but reads muddy under text). --color-on-accent is contrast-picked; yellow is never text. Recomputed live on theme switch. Inspector + catalog-card webviews apply at boot; brand.css statics remain the no-JS fallback. Pill atom gains a dot-less badge variant (dot = process state; badges describe things). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Middle slice of the UX1 stack (2/3), no interview dependency — the brand accent system for ALL webviews.
brand_accent.tssolves the deployed accent from the active theme at boot: canonical#FFF676ships exactly wherever contrast vs the editor background clears 3:1 (all dark themes); light themes get the closest-to-brand gold (lightness binary-searched, hue+chroma held, gamut-clamped). Two tokens with different jobs: lines (--color-accent, contrast-solved — borders/rings/marks) and fills (--color-accent-fill, always the brand lemon: black text on it ≈ 19:1, where a 3:1-darkened gold passes WCAG arithmetic but reads muddy).--color-on-accentis contrast-picked; yellow is never text. Recomputes live on theme switch; brand.css statics are the no-JS fallback. Pill atom gains a dot-less badge variant.6 solver unit tests (brand-exact on dark/gray, hue-held solve on light, fill/text invariants, color parsing, OKLCH round-trip).
Stack: #template-params → this → #82.
🤖 Generated with Claude Code