Skip to content

Conversation

@joeyouss
Copy link
Collaborator

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: __________________________________
  • Jira/GitHub Issue numbers (if any): ______________________________
  • Preview links/images (Internal contributors only): __________________

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@joeyouss joeyouss changed the title [CCM revamp] new nav bar for CCM [CCM revamp 1/n] New Navbar for CCM docs Mar 25, 2025
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67e298a9a8f57d00820c053e--harness-developer.netlify.app

sdsingh07
sdsingh07 previously approved these changes Mar 25, 2025
ivikramsahu
ivikramsahu previously approved these changes Mar 25, 2025
Copy link
Collaborator

@ivikramsahu ivikramsahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@richardblack-Harness richardblack-Harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, all in all this is a great start.

Rohit-Kaliki
Rohit-Kaliki previously approved these changes Mar 26, 2025
wei-harness
wei-harness previously approved these changes Mar 27, 2025
Copy link
Collaborator

@wei-harness wei-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67f6f5e715bcd8d00365285c--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67f6fa9a9a4a9bdd709905ca--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67f7c086300e306d330926d3--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67f80309ce6dab3923ae98c9--harness-developer.netlify.app

@joeyouss
Copy link
Collaborator Author

@wei-harness @pratmit can you please approve the changes? I am blocked on this to merge

CC @Rohit-Kaliki @raviyadalam

@joeyouss joeyouss merged commit 924bfc7 into main Apr 14, 2025
3 checks passed
@joeyouss joeyouss deleted the new-nav branch April 14, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants