Skip to content

A11y safari#1

Open
harshit-browserstack wants to merge 8 commits into
mainfrom
a11y-safari
Open

A11y safari#1
harshit-browserstack wants to merge 8 commits into
mainfrom
a11y-safari

Conversation

@harshit-browserstack
Copy link
Copy Markdown
Owner

Proposed changes

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the BrowserStack service’s Accessibility Automation capability validation to support additional desktop browsers (Safari and Chrome for Testing) with explicit minimum version requirements, and extends unit tests accordingly.

Changes:

  • Extend validateCapsWithA11y and validateCapsWithNonBstackA11y to allow Safari and Chrome for Testing, with min-version checks.
  • Introduce min-version constants for BrowserStack vs non-BrowserStack infrastructure validation paths.
  • Update/add unit tests to cover Safari 18.4+ and Chrome for Testing 141+ scenarios and new warning messages.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
packages/wdio-browserstack-service/src/util.ts Expands a11y capability validation logic to include Safari and Chrome for Testing with min-version checks and updated warnings.
packages/wdio-browserstack-service/src/constants.ts Adds supported-browser and minimum-version constants for a11y validation.
packages/wdio-browserstack-service/tests/util.test.ts Updates existing tests and adds new cases for Safari/ChromeForTesting validation behavior and warnings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/wdio-browserstack-service/src/util.ts Outdated
Comment thread packages/wdio-browserstack-service/src/util.ts
Comment thread packages/wdio-browserstack-service/src/constants.ts
Comment thread packages/wdio-browserstack-service/src/util.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants