feat(v11)!: restrict size/first/last magic keys to arrays and strings#915
Closed
harttle wants to merge 3 commits into
Closed
feat(v11)!: restrict size/first/last magic keys to arrays and strings#915harttle wants to merge 3 commits into
harttle wants to merge 3 commits into
Conversation
readSize, readFirst, and readLast bypassed the ownPropertyOnly guard by reading inherited properties from the prototype chain. Pass the flag through and only allow prototype size lookups when ownPropertyOnly is false. Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage Report for CI Build 27838558883Coverage remained the same at 99.543%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Co-authored-by: Cursor <cursoragent@cursor.com>
Replace ownPropertyOnly guards with simpler v11 semantics: magic property resolution applies only to arrays and strings. Plain objects no longer get Object.keys size or first/last fallbacks. Related to #916 Co-authored-by: Cursor <cursoragent@cursor.com>
harttle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft / WIP — planned breaking change for v11. Related to #916.
size,first, andlastto arrays and strings onlyObject.keyscount for.sizeorobj['first']/obj['last']magic fallbacks.sizeis no longer resolved via magic (still accessible as a normal property whenownPropertyOnly: false)size/first/laston objects remain accessible via regular property lookupownPropertyOnlyguard approach with simpler, safer semanticsBreaking changes
{}.size-> key count.size->undefined{}.first/.last->obj['first']/obj['last'].first/.last->undefined(unless own property).sizeundefinedwith defaultownPropertyOnly; native.sizewhenownPropertyOnly: falseTest plan
npm run buildjest src/context/context.spec.tsjest test/e2e/issues.spec.tsFixes #916