Conversation
Now the user can specify LDFLAGS and CPPFLAGS in PROLOGUE and they will not be overriden later.
Contributor
|
Interesting. Wouldn't we better off setting "base" LDFLAGS and CPPFLAGS as parameters? PROLOGUE is a last-ditch workaround when we can't do anything else. |
Member
Author
|
See here for motivation: https://groups.google.com/d/topic/hashdist/3PvxWc8qa2M/discussion, and then let's see if there is another way to do what was proposed on the list. |
Member
Author
|
This PR is not needed anymore, as #646 fixes my problem. I don't know if this could be useful for some other uses or not. I am closing it for now, we can reopen later if the need arises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the user can specify LDFLAGS and CPPFLAGS in PROLOGUE and they will not be
overriden later.