Conversation
The patch adds @@artifact@@ at the proper place in the source code and we then replace it for ${ARTIFACT} using sed.
There was a problem hiding this comment.
I think these two blobs can just be merged into one. I'll do it after my gcc build finishes.
There was a problem hiding this comment.
This line assumes that ${ARTIFACT} does not contain the | character. If it does, then the sed command will break.
There was a problem hiding this comment.
@ahmadia I've searched the web and there doesn't seem to be any solution really to this, except to manually escape the variable to be substituted. I think it will also fail if the variable contains []. I am inclined to just leave this be (it should work for most paths), unless we can figure out a better solution.
There was a problem hiding this comment.
You can use other separator but I would assume that "|" is fairly safe for a path. It is safer than ":" which we could use if there was more than one path.
There was a problem hiding this comment.
Right. The ${ARTIFACT} path can contain both : and |, so to be completely safe, one would need to escape it, but it just makes the code really messy.
|
I am now running my big stack using gcc built using this PR. So far it works great! I will post once it finishes. |
|
If all works on my computer, then I would propose to merge this. Somebody with Darwin should then test the patch at #645 (comment) and submit a new PR. |
|
Ok, my (huge) stack installed, including the gcc itself (using gcc from this PR), using the gcc from this PR. This is ready to go in. @ahmadia any objections against merging this? |
|
Looks good. |
|
Thanks, merging. |
Make gcc embed rpath automatically
3 participants
The patch adds @@artifact@@ at the proper place in the source code and we then
replace it for ${ARTIFACT} using sed.