fix: missing url encode multipart object keys#17
Open
Nana-EC wants to merge 3 commits into
Open
Conversation
Nana-EC
changed the title
createMultipartUpload(), multipartUploadPart(), completeMultipartUpload(), and abortMultipartUpload() were concatenating the raw object key into the request URL without encoding. Keys containing spaces, +, #, or other reserved characters produced malformed URLs and incorrect SigV4 signatures, causing request failures. Apply urlEncode(key, true) consistently across all four methods, matching the existing behaviour of uploadTextFile() and downloadTextFile(). Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
#13) Two regression tests: - uploadFile() with a key containing spaces and + completes successfully and the object is retrievable under the correct key via MinIO. - abortMultipartUpload() with a special-character key removes the upload ID from listMultipartUploads() as expected. Before the fix both tests would produce malformed URLs and fail with authentication or network errors. Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
force-pushed
the
13-url-encode-multipart-object-keys
branch
from
102d358 to
2f8b481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
createMultipartUpload(), multipartUploadPart(), completeMultipartUpload(), and abortMultipartUpload() were concatenating the raw object key into the request URL without encoding. Keys containing spaces, +, #, or other reserved characters produced malformed URLs and incorrect SigV4 signatures, causing request failures.
and the object is retrievable under the correct key via MinIO.
ID from listMultipartUploads() as expected.
Before the fix both tests would produce malformed URLs and fail with
authentication or network errors.
Related issue(s):
Fixes #13
Notes for reviewer:
Checklist