fix: missing url encode listobjects prefix#18
Open
Nana-EC wants to merge 3 commits into
Open
Conversation
The prefix was concatenated raw into the canonical query string. A prefix containing &, =, +, spaces, or other reserved characters would corrupt the query string structure and produce an incorrect SigV4 canonical query string, causing authentication failures. Apply urlEncode(prefix, false) so the value is safely percent-encoded before being embedded in the query string. Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Regression test: upload objects under a key prefix that contains a space, then call listObjects() with that prefix. Before the fix, the unencoded space in the URL caused URISyntaxException (wrapped as UncheckedIOException); after the fix the correct objects are returned and unrelated keys are excluded. Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
force-pushed
the
14-url-encode-listobjects-prefix
branch
from
031fd41 to
6980b13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The prefix was concatenated raw into the canonical query string.
A prefix containing &, =, +, spaces, or other reserved characters would corrupt the query string structure and produce an incorrect SigV4 canonical query string, causing authentication failures.
Related issue(s):
Fixes #14
Notes for reviewer:
Checklist