Skip to content

chore: remove workarounds previously implemented#245

Merged
nathanklick merged 2 commits intomainfrom
00243-Remove-Workaround
Aug 4, 2023
Merged

chore: remove workarounds previously implemented#245
nathanklick merged 2 commits intomainfrom
00243-Remove-Workaround

Conversation

@nathanklick
Copy link
Copy Markdown
Member

@nathanklick nathanklick commented Aug 3, 2023 •
edited
Loading

Description

This pull request changes the following:

  • Removes the workaround previously added for exposing the environment variables to the systemd daemon in the ubi8-init-java17 container image.

Related Issues

@nathanklick
chore: remove workarounds previously implemented
7b9823d 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick marked this pull request as draft August 3, 2023 22:14
@nathanklick nathanklick self-assigned this Aug 3, 2023
@nathanklick nathanklick added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Aug 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 3, 2023 •
edited
Loading

Unit Test Results

13 files  ±0  13 suites  ±0   36s ⏱️ +5s
57 tests ±0  54 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
58 runs  ±0  55 ✔️ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit ed95586. ± Comparison against base commit 92032f9.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #245 (ed95586) into main (92032f9) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #245   +/-   ##
=========================================
  Coverage     54.68%   54.68%           
  Complexity      219      219           
=========================================
  Files            47       47           
  Lines          1046     1046           
  Branches        129      129           
=========================================
  Hits            572      572           
  Misses          424      424           
  Partials         50       50

Impacted file tree graph

@nathanklick nathanklick marked this pull request as ready for review August 3, 2023 23:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nathanklick nathanklick merged commit 2e07219 into main Aug 4, 2023
@nathanklick nathanklick deleted the 00243-Remove-Workaround branch August 4, 2023 00:12
@swirlds-automation
Copy link
Copy Markdown
Contributor

swirlds-automation commented Aug 4, 2023

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Copy Markdown
Contributor

swirlds-automation commented Aug 8, 2023

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leninmehedy leninmehedy leninmehedy approved these changes

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds

Assignees

@nathanklick nathanklick

Labels

Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. released on @0.5.x released

Projects

None yet

Milestone

No milestone

3 participants

@nathanklick @swirlds-automation @leninmehedy