feat: unrecognized enum values null/default bug#738
Merged
anthony-swirldslabs merged 1 commit intomainfrom Feb 4, 2026
Merged
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
imalygin
approved these changes
Feb 4, 2026
artemananiev
approved these changes
Feb 4, 2026
Integration Test Report 415 files ±0 415 suites ±0 15m 28s ⏱️ - 2m 34s Results for commit dd3cde9. ± Comparison against base commit b8a49b0. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The PR fixes a bug in the current enum implementation (after support for
UNRECOGNIZEDvalues was added) that causes PBJ to returnUNRECOGNIZEDinstead of the "default" value as the protobuf spec prescribes.Also, marking it as
feat:to make a new minor release because I realized that theUNRECOGNIZEDenum feature is a major API change because it adds an extra constant to every enum and sometimes requires modifying the client code (e.g. adding acaseto aswitch.)Related issue(s):
Fixes #737
Notes for reviewer:
All tests, including the newly added one for this bug, should pass.
Checklist