Skip to content

feat: support maxSize in PbjGrpcClient#753

Merged
anthony-swirldslabs merged 1 commit intomainfrom
748-grpcClientMaxSize
Mar 13, 2026
Merged

feat: support maxSize in PbjGrpcClient#753
anthony-swirldslabs merged 1 commit intomainfrom
748-grpcClientMaxSize

Conversation

@anthony-swirldslabs
Copy link
Contributor

Description:
Adding support for configuring a custom maxSize for the PBJ GRPC Client so that it's able to receive messages larger than 2MB (per the current Codec.DEFAULT_MAX_SIZE.)

Related issue(s):

Fixes #748

Notes for reviewer:
A new integration test is added to verify the behavior. W/o the fix, or w/o specifying the maxSize in the client config, the test fails with a ParseException about the size of the payload exceeding the limit.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
@anthony-swirldslabs anthony-swirldslabs self-assigned this Mar 13, 2026
@anthony-swirldslabs anthony-swirldslabs requested review from a team as code owners March 13, 2026 21:00
@github-actions
Copy link

JUnit Test Report

   78 files  ±0     78 suites  ±0   4m 2s ⏱️ -7s
1 352 tests ±0  1 348 ✅ ±0   4 💤 ±0  0 ❌ ±0 
7 229 runs  ±0  7 209 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 55b3b11. ± Comparison against base commit d395714.

@github-actions
Copy link

Integration Test Report

    415 files  ±0      415 suites  ±0   17m 31s ⏱️ + 2m 25s
114 889 tests +1  114 889 ✅ +1  0 💤 ±0  0 ❌ ±0 
115 131 runs  +2  115 131 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 55b3b11. ± Comparison against base commit d395714.

This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007e293cc5d328@4471df24
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007e293cc5d558@18d1ddde
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007e293cc5d788@28a794d4
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007dda38c3cce8@408beabf
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007dda38c3cf18@58c54ee1
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007dda38c3d148@69c50add
com.hedera.pbj.integration.test.grpc.GrpcClientComprehensiveTest ‑ testUnaryMethodReceivingExtraLargePayload()

Copy link

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!!

@anthony-swirldslabs anthony-swirldslabs merged commit 9cc32d7 into main Mar 13, 2026
15 checks passed
@anthony-swirldslabs anthony-swirldslabs deleted the 748-grpcClientMaxSize branch March 13, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GRPC: support custom maxSize

3 participants