fix: propagate maxSize to PbjGrpcDatagramReader#757
Merged
anthony-swirldslabs merged 2 commits intomainfrom Mar 16, 2026
Merged
fix: propagate maxSize to PbjGrpcDatagramReader#757anthony-swirldslabs merged 2 commits intomainfrom
anthony-swirldslabs merged 2 commits intomainfrom
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
imalygin
previously approved these changes
Mar 13, 2026
AlfredoG87
approved these changes
Mar 13, 2026
jsync-swirlds
previously approved these changes
Mar 13, 2026
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
anthony-swirldslabs
dismissed stale reviews from jsync-swirlds and imalygin
via
9960c69
jsync-swirlds
approved these changes
Mar 14, 2026
imalygin
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Removing a hardcoded 10MB limit in the PbjGrpcDatagramReader and making it a parameter based on the PbjGrpcClientConfig.
Related issue(s):
Fixes #756
Notes for reviewer:
All tests should pass.
Checklist