Merged
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
imalygin
approved these changes
Apr 2, 2026
jsync-swirlds
approved these changes
Apr 2, 2026
andrewb1269
approved these changes
Apr 3, 2026
Contributor
andrewb1269
left a comment
andrewb1269
left a comment
There was a problem hiding this comment.
Approve the workflow files.
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The upgrade is motivated by warnings about the
sun.misc.Unsafeusages that get printed when a client application using the PBJ runs on modern Java. Methods in the Unsafe class are terminally deprecated and will be removed in a future JDK version. So we have to replace their usages with modern alternatives.I'm using the
VarHandle(Java 9+) to access arrays. Also, I'm usingMemorySegment(Java 22+) for operations on buffers.Since this is a breaking change, I'm bumping the snapshot version to 0.15.0 and will release this new version once the PR is merged.
Related issue(s):
Fixes #750
Notes for reviewer:
All tests, both unit and integration, pass.
Checklist