Skip to content

feat: cleanup additional imported packages#13

Merged
nathanklick merged 1 commit intomainfrom
00011-more-cleanup
Jul 22, 2025
Merged

feat: cleanup additional imported packages#13
nathanklick merged 1 commit intomainfrom
00011-more-cleanup

Conversation

@nathanklick
Copy link
Member

Description

This pull request removes the pkg/detect package and all related functionality, including memory detection, OS information retrieval, and associated tests. It also updates the Taskfile.yaml to stop generating mocks for the removed package. Below is a summary of the most important changes:

Removal of pkg/detect functionality:

  • pkg/detect/detect.go: Removed the main implementation of memory detection and OS-related functionalities, including interfaces such as MemoryDetector, MemoryManager, and OSDetector.
  • pkg/detect/global.go: Removed utility functions for memory size parsing, human-readable formatting, and buffer calculations.
  • pkg/detect/memory.go: Removed the memoryManager implementation, which handled memory-related operations such as validating memory requirements and calculating reserved memory.
  • pkg/detect/memory_detector.go: Removed the systemMemoryDetector, which used the github.com/pbnjay/memory library to fetch system memory details.
  • pkg/detect/logging.go: Removed logging-related constants and fields specific to the pkg/detect package.

Removal of tests for pkg/detect:

  • pkg/detect/global_test.go: Deleted tests for memory size parsing, human-readable formatting, buffer calculations, and Java memory specifications.

Updates to Taskfile.yaml:

  • Taskfile.yaml: Removed the command to generate mocks for pkg/detect as the package has been deleted.

Related Issues

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick marked this pull request as ready for review July 22, 2025 01:53
@nathanklick nathanklick requested a review from a team as a code owner July 22, 2025 01:53
@nathanklick nathanklick self-assigned this Jul 22, 2025
@nathanklick nathanklick merged commit 365b711 into main Jul 22, 2025
5 checks passed
@nathanklick nathanklick deleted the 00011-more-cleanup branch July 22, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup imported code to remove unnecessary packages

2 participants