feat: cleanup additional imported packages#13
Merged
nathanklick merged 1 commit intomainfrom Jul 22, 2025
Merged
Conversation
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
leninmehedy
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
pkg/detectpackage and all related functionality, including memory detection, OS information retrieval, and associated tests. It also updates theTaskfile.yamlto stop generating mocks for the removed package. Below is a summary of the most important changes:Removal of
pkg/detectfunctionality:pkg/detect/detect.go: Removed the main implementation of memory detection and OS-related functionalities, including interfaces such asMemoryDetector,MemoryManager, andOSDetector.pkg/detect/global.go: Removed utility functions for memory size parsing, human-readable formatting, and buffer calculations.pkg/detect/memory.go: Removed thememoryManagerimplementation, which handled memory-related operations such as validating memory requirements and calculating reserved memory.pkg/detect/memory_detector.go: Removed thesystemMemoryDetector, which used thegithub.com/pbnjay/memorylibrary to fetch system memory details.pkg/detect/logging.go: Removed logging-related constants and fields specific to thepkg/detectpackage.Removal of tests for
pkg/detect:pkg/detect/global_test.go: Deleted tests for memory size parsing, human-readable formatting, buffer calculations, and Java memory specifications.Updates to
Taskfile.yaml:Taskfile.yaml: Removed the command to generate mocks forpkg/detectas the package has been deleted.Related Issues