Migrate more testing helpers into tfdiags package #36474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
force-pushed
the
sarah/diags-comparisons-refactor-2
branch
from
127c61f to
457b09a
Compare
SarahFrench
force-pushed
the
sarah/diags-comparisons-refactor-2
branch
from
457b09a to
c03e7d7
Compare
SarahFrench
commented
Mar 24, 2025
Member
Author
SarahFrench
left a comment
SarahFrench
left a comment
There was a problem hiding this comment.
Highlighting where the helper functions used to be located
Comment on lines
-1000
to
-1016
| func assertNoDiagnostics(t *testing.T, diags tfdiags.Diagnostics) bool { | ||
| t.Helper() | ||
| return assertDiagnosticCount(t, diags, 0) | ||
| } | ||
|
|
||
| func assertDiagnosticCount(t *testing.T, diags tfdiags.Diagnostics, want int) bool { | ||
| t.Helper() | ||
| if len(diags) != want { | ||
| t.Errorf("wrong number of diagnostics %d; want %d", len(diags), want) | ||
| for _, diag := range diags { | ||
| t.Logf("- %#v", diag) | ||
| } | ||
| return true | ||
| } | ||
| return false | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Removed functions here
Member
Author
There was a problem hiding this comment.
This is the other place where helper functions were moved from
radeksimko
approved these changes
Mar 24, 2025
rkoron007
pushed a commit
that referenced
this pull request
Mar 27, 2025
* Add new `AssertNoDiagnostics` and `AssertDiagnosticCount` test helpers in tfdiags package * Add new `AssertNoErrors` and `LogDiagnostics` test helpers in tfdiags package * Refactor existing tests to use new helpers * Refactor more recent tests * Revert change - wrong function replaced * Refactor to account for function no longer returning a boolean * Fix comment
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves these functions into testing.go in the tfdiags package:
Removes implementations of these functions from other packages
Refactors existing tests to use the new helpers in tfdiags
Target Release
N/A
CHANGELOG entry