migrate command for terraform stacks #36482
Conversation
dsa0x
force-pushed
the
sams/tfstacks-migrate
branch
from
64c0395 to
e07a751
Compare
dsa0x
added
the
no-changelog-needed
dsa0x
force-pushed
the
sams/tfstacks-migrate
branch
from
b151767 to
22bf079
Compare
dsa0x
changed the title
dsa0x
force-pushed
the
sams/tfstacks-migrate
branch
from
39cf8e9 to
c994424
Compare
dsa0x
force-pushed
the
sams/tfstacks-migrate
branch
from
3cfde5a to
3b4976b
Compare
liamcervante
left a comment
liamcervante
left a comment
There was a problem hiding this comment.
I think this looks good overall, just a couple of suggestions!
dsa0x
force-pushed
the
sams/tfstacks-migrate
branch
from
60b9f0b to
00a362b
Compare
dsa0x
force-pushed
the
sams/tfstacks-migrate
branch
from
00a362b to
125e537
Compare
| } | ||
|
|
||
| if resource.Module.IsRoot() { | ||
| // If there is no resource mapping, we check for a root module mapping |
There was a problem hiding this comment.
I think we should be explicit here to begin with - it is safer to loosen restrictions later than to tighten them so I think either return an error for now and we can add this later if needed.
liamcervante
left a comment
liamcervante
left a comment
There was a problem hiding this comment.
sorry, small nit - but looks good otherwise
| if ok { | ||
| inst, diags := parseComponentInstance(target) | ||
| if diags.HasErrors() { | ||
| return ret, diags | ||
| } | ||
| ret.AbsResource = stackaddrs.AbsResource{ | ||
| Component: inst, | ||
| Item: resource, | ||
| } | ||
| return ret, diags | ||
| } else { | ||
| diags = diags.Append(tfdiags.Sourceless(tfdiags.Error, "Resource not found", fmt.Sprintf("Resource %q not found in mapping.", resource.Resource.String()))) | ||
| return ret, diags | ||
| } |
There was a problem hiding this comment.
nit: don't need this if-else statement anymore
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
3 participants
This adds a new stacks command for migrating from module terraform state to terraform stack state. The Client is expected to consume this via the rpcapi.
Target Release
1.11.x
CHANGELOG entry