-
Notifications
You must be signed in to change notification settings - Fork 10.2k
fix element function documentation #36710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is the change that enabled this functionality: #35501 |
| ``` | ||
| > element(["a", "b", "c"], length(["a", "b", "c"])-1) | ||
| > element(["a", "b", "c"], -1) | ||
| c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run this, the output I get is:
"c"
This is true for the other examples as well. Is this system-dependent? (I am on MacOS.) If not, we should update the output to be correct as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, "c" is always correct, because it is a quoted string value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crw Ok for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @crw
That's done.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
element function support negative index starting in version 1.10.0, but documentation still says that it doesn't support it.
Target Release
1.12.x
CHANGELOG entry