Add test coverage for local backend's backend.Backend methods and behaviours
#36750
+364
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
changed the title
local backend's backend.Backend methods and behaviours
…d on the internal backend inside the local backend Also improve comments
2 tasks
jbardin
approved these changes
Mar 24, 2025
Member
Author
|
Thanks! |
rkoron007
pushed a commit
that referenced
this pull request
Mar 27, 2025
…ehaviours (#36750) * Test the `local` backend's PrepareConfig method * Update `testTmpDir` helper to return temp directory name * Add comments to existing test * Move helper function to bottom of file * Add tests to show how path attribute is used in the local backend * Add tests to show how workspace_dir attribute is used in the local backend * Reorder tests * Update test so that it confirms all backend.Backend methods are called on the internal backend inside the local backend Also improve comments * Fix imports
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some more test coverage to the local backend's backend.Backend methods and behaviours storing state.
These tests are being pulled out of #36718
Target Release
1.12.x
CHANGELOG entry