Skip to content

Terraform Test: cleanup command #36847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsa0x merged 13 commits into from
Apr 17, 2025
Merged

Terraform Test: cleanup command #36847

dsa0x merged 13 commits into from
Apr 17, 2025

Conversation

@dsa0x
Copy link
Member

@dsa0x dsa0x commented Apr 4, 2025

Fixes #

Target Release

1.13.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 4, 2025
@dsa0x dsa0x force-pushed the sams/cmd-test-cleanup branch from 8234ee5 to d2a1c7c Compare April 4, 2025 08:51
@dsa0x dsa0x force-pushed the sams/cmd-test-cleanup branch from daac5b0 to b0b4ac2 Compare April 14, 2025 14:16
@dsa0x dsa0x marked this pull request as ready for review April 14, 2025 14:18
@dsa0x dsa0x requested a review from a team as a code owner April 14, 2025 14:18
liamcervante
liamcervante reviewed Apr 15, 2025
View reviewed changes
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like how you managed to reuse the same nodes from the main test command!

SarahFrench
SarahFrench reviewed Apr 15, 2025
View reviewed changes
@dsa0x dsa0x force-pushed the sams/cmd-test-cleanup branch from 409ba85 to 3ae597b Compare April 16, 2025 06:25
dsa0x and others added 4 commits April 16, 2025 12:19
@dsa0x
More test documentation
dbcb0e1
@dsa0x
command docs
1d1850d
@dsa0x @SarahFrench
Apply suggestions from code review
432de01 
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
@dsa0x
address comments
c760feb
@dsa0x dsa0x force-pushed the sams/docs-and-test branch from 576420a to c760feb Compare April 16, 2025 10:22
@dsa0x dsa0x requested a review from a team as a code owner April 16, 2025 10:22
Base automatically changed from sams/docs-and-test to f-controlling-destroys April 16, 2025 11:15
@dsa0x dsa0x merged commit 15ea484 into f-controlling-destroys Apr 17, 2025
8 checks passed
@dsa0x dsa0x deleted the sams/cmd-test-cleanup branch April 17, 2025 12:06
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@liamcervante liamcervante liamcervante approved these changes

@SarahFrench SarahFrench Awaiting requested review from SarahFrench

Assignees

No one assigned

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsa0x @SarahFrench @liamcervante