-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Backport of Update iframe to VideoEmbed into v0.13 #36947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of Update iframe to VideoEmbed into v0.13 #36947
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
The old branches (<= 0.15) are now locked so I think this will need to be addressed after the docs migration when the content is outside of this repository. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Backport
This PR is auto-generated from #36943 to be assessed for backporting due to the inclusion of the label 0.13-backport.
🚨
The person who merged in the original PR is:
@im2nguyen
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
This updates the existing iframe for youtube to a
VideoEmbedcomponent. This is so we can standardize how we are serving and tracking video plays across DevDot.Related PR: hashicorp/dev-portal#2699
Fixes #
Target Release
1.13.x
CHANGELOG entry
Overview of commits