fixes: Some architectural deviations - #93
Merged
brandonc merged 2 commits intoJul 29, 2026
Merged
Conversation
- Using `auth login --dry-run` no longer opens a web browser. --dry-run now appears in argument autocomplete lists. - Using `profile display --markdown` no longer produces an error. - Removed Token property from json output when using `profile profiles list --json`, preventing accidental exposure.
Maed223
approved these changes
Jul 29, 2026
Comment on lines
+255
to
+258
| profile := opts.Profile | ||
|
|
||
| profile.Token = token | ||
| if err := profile.Write(); err != nil { |
Collaborator
There was a problem hiding this comment.
Any reason for adding this intermediate var? Seems redudant since we're copying the pointer
Collaborator
Author
There was a problem hiding this comment.
At first I wrote a version that removed the pointer from the opts but ended up putting it back. This local is left over from that churn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
auth login --dry-runno longer opens a web browser.--dry-runnow appears in argument autocomplete lists.profile display --markdownno longer produces an error.profile profiles list --json, preventing accidental exposure.Example Output
Before:
PR Checklist
npx changie newor install changie to prepare a new changelog entry for the next set of release notes.--json— Force machine readable output to stdout. Does not apply to stderr.--markdown— Force markdown output to stdout. Does not apply to stderr.--dry-run— Don't make any actual writes or other mutations. Describe what would have changed to stderr.--quiet— Only render essential content.make gen/screenshotif the root command output changes.Autocompletefield to positional arguments and flags to assist shell autocomplete.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.