feat: verify release zip sha256 in mcp#19
Merged
Conversation
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 最終レビューの将来 hardening 残件「バイナリ SHA256 検証」を実装する。
SHA256SUMS(sha256sum 形式)を生成し、5 個目のリリースアセットとして公開ensureCli: zip ダウンロード後に同リリースのSHA256SUMSと照合。不一致・エントリ欠落は throw し、破損 zip をキャッシュ・実行しないdownloadのエラーにstatusを付与して message 文字列解析を回避)v0.2.0 リリースには SHA256SUMS が無いため、検証が効き始めるのは次のリリースから(それまでは 404 skip + stderr ログ)。Editor(C#)側のダウンローダは未検証のまま — 将来の parity 課題。
Test plan
shasum -a 256出力に対する end-to-end 照合をローカル確認(dist ビルド経由)