fix: make GHES base URL setting actually work#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 レビューで発覚した実質バグの修正:
manifest.jsonのhost_permissions/content_scriptsが github.com 固定のため、Options の baseUrl(GHES)設定が機能していなかった。optional_host_permissions(https://*/*,http://127.0.0.1/*) とscriptingpermission を追加chrome.scripting.registerContentScriptsで content.js を動的登録(固定 idprefablens-ghes、baseUrl 変更時は登録し直し、github.com へ戻したら解除)Saved (host permission declined)を表示protocol//hostname/*で構築(ポートなしは全ポート一致)— 後続の full-stack E2E がローカルサーバをこの経路で使う予定Test plan
npm run typecheck && npm test(59 tests)npm run build && npm run e2e(smoke 2 本)