Skip to content

fix: make GHES base URL setting actually work#7

Merged
hashiiiii merged 5 commits into
mainfrom
fix/ghes-host-registration
Jul 4, 2026
Merged

fix: make GHES base URL setting actually work#7
hashiiiii merged 5 commits into
mainfrom
fix/ghes-host-registration

Conversation

@hashiiiii

Copy link
Copy Markdown
Owner

Summary

Phase 2 レビューで発覚した実質バグの修正: manifest.jsonhost_permissions / content_scripts が github.com 固定のため、Options の baseUrl(GHES)設定が機能していなかった。

  • optional_host_permissions (https://*/*, http://127.0.0.1/*) と scripting permission を追加
  • Options の Save(user gesture 内)で GHES オリジンの権限を要求し、chrome.scripting.registerContentScripts で content.js を動的登録(固定 id prefablens-ghes、baseUrl 変更時は登録し直し、github.com へ戻したら解除)
  • 権限拒否時は保存はしつつ Saved (host permission declined) を表示
  • match pattern はポート記述不可のため protocol//hostname/* で構築(ポートなしは全ポート一致)— 後続の full-stack E2E がローカルサーバをこの経路で使う予定
  • あわせて Phase 2 follow-ups の spec / plan doc を追加

Test plan

  • npm run typecheck && npm test(59 tests)
  • npm run build && npm run e2e(smoke 2 本)
  • CI green を確認して自己マージ(workflow-autonomy)

@hashiiiii
hashiiiii merged commit 4d6eb25 into main Jul 4, 2026
3 checks passed
@hashiiiii
hashiiiii deleted the fix/ghes-host-registration branch July 4, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant