SRE-927: Ignore the concurrency.queue syntax gap - #102
Conversation
PR SummaryLow Risk Overview The existing SRE-941 TODO is extended to drop this ignore alongside the Reviewed by Cursor Bugbot for commit d7a1c9b. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
Updates the reusable actionlint preflight workflow to suppress a known false-positive triggered by GitHub Actions’ concurrency.queue syntax, which actionlint v1.7.12 does not yet recognize (tracked for later removal alongside existing $/ ignores).
Changes:
- Add a third
-ignorepattern to filter theconcurrency.queue“unexpected key" lint message. - Expand the TODO comment to track both upstream actionlint gaps (
$/andconcurrency.queue) under SRE-941.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Purpose
actionlint 1.7.12 does not know the
concurrency.queuekey (rhysd/actionlint#654), whichhashintel/hashuses in its deploy workflow. Same category as the$/ignores from #100: a real GitHub feature the linter lags behind on.Related links
What does this change?
-ignoreon the actionlint step for theconcurrency.queuesyntax-check message, tracked for removal in SRE-941 alongside the$/ignoresThe intermediate commit gating shellcheck at error level is reverted — findings in the consumer repos get fixed instead (SRE-927 fleet PRs).