Skip to content

FE-698: Scenario runner + observer scenario composition#102

Merged
lunelson merged 4 commits into
mainfrom
ln/fe-698-slice-b
May 8, 2026
Merged

FE-698: Scenario runner + observer scenario composition#102
lunelson merged 4 commits into
mainfrom
ln/fe-698-slice-b

Conversation

@lunelson
Copy link
Copy Markdown
Contributor

@lunelson lunelson commented May 7, 2026

Stack Context

This FE-698 stack establishes reusable prompt/context machinery and a pre-UI scenario substrate for evaluating agent behavior.

What?

  • Adds a deterministic no-provider scenario artifact builder for prompt probes.
  • Composes observer-capture scenarios from the typed observer context pack and production observer prompt composition.
  • Extracts observer prompt composition into a pure module and makes prompt sources explicit (asset vs composed).

Why?

Brunch needs repeatable prompt probe artifacts before adding real provider/harness execution. This PR proves the artifact shape and observer scenario composition while keeping provider/Pi/runtime authority out of the substrate.

@lunelson lunelson changed the title FE-698 add scenario runner capture skeleton FE-698: Prompt/context substrate slice 2 May 7, 2026
@lunelson lunelson marked this pull request as ready for review May 7, 2026 15:44
@cursor
Copy link
Copy Markdown

cursor Bot commented May 7, 2026

PR Summary

Medium Risk
Medium risk because it refactors the production observer system-prompt composition into a new module and introduces new prompt-loading APIs; any subtle prompt-string change could impact observer extraction behavior.

Overview
Introduces a lightweight scenario runner that builds deterministic, no-provider “probe artifacts” for prompt/context scenarios (currently observer-capture), including stable serialization and validation that prompt assets don’t contain unresolved template variables.

Refactors observer prompt composition by extracting buildObserverSystemPrompt into a new pure observer-prompt.ts module, and extends the prompt loader with getPromptAssetFileName so probe artifacts can record the underlying markdown asset name. Documentation/spec registers are updated to mark the scenario runner as completed/covered (scenario-runner.test.ts).

Reviewed by Cursor Bugbot for commit 8d9ab97. Bugbot is set up for automated code reviews on this repo. Configure here.

@lunelson lunelson self-assigned this May 7, 2026
@lunelson lunelson requested a review from kostandinang May 7, 2026 15:45
@lunelson lunelson changed the title FE-698: Prompt/context substrate slice 2 FE-698: Scenario runner + observer scenario composition May 7, 2026
Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/server/scenario-runner.ts Outdated
kostandinang
kostandinang previously approved these changes May 8, 2026
@graphite-app graphite-app Bot changed the base branch from ln/fe-698-slice-a to graphite-base/102 May 8, 2026 10:37
@lunelson lunelson force-pushed the ln/fe-698-slice-b branch from c99d056 to 8d9ab97 Compare May 8, 2026 10:46
@lunelson lunelson force-pushed the graphite-base/102 branch from 204af9d to b83ff5f Compare May 8, 2026 10:46
@github-actions github-actions Bot dismissed kostandinang’s stale review May 8, 2026 10:46

Latest approval commit c99d056 is not an ancestor of 8d9ab97, indicating rewritten history after approval

@graphite-app graphite-app Bot changed the base branch from graphite-base/102 to main May 8, 2026 10:46
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 8, 2026

Merge activity

  • May 8, 10:46 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@kostandinang kostandinang self-requested a review May 8, 2026 11:00
@lunelson lunelson added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit f1f4ad2 May 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants