FE-1141: Add readable run evidence and graph traceability#303
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryMedium Risk Overview Run detail & projections: Graph traceability: New Replanning (RPC + core): Web-callable Workspace home: Loads run list, shows run counts/previews and active-spec progress hints from graph overview. Docs / planning: Updates D111-L / I58-L for FE-1166 Tests: Host-promotion port tests use repo-local scratch dirs with Reviewed by Cursor Bugbot for commit 0486ec8. Bugbot is set up for automated code reviews on this repo. Configure here. |
5781120 to
4da2942
Compare
e10205f to
86756d7
Compare
4da2942 to
f4dbc18
Compare
1d138bd to
f76437d
Compare
f4dbc18 to
11bdf56
Compare
f76437d to
f87bfcc
Compare
11bdf56 to
057b2d3
Compare
f87bfcc to
047123f
Compare
057b2d3 to
a7b56dc
Compare
34e091e to
ccb4d73
Compare
lunelson
left a comment
There was a problem hiding this comment.
The observer/readability pieces look coherent, and the run evidence UI is much easier to follow.
I think the web replanning controls need one product-entry check before merge. The buttons call execute.replanRegeneratePlan, execute.replanStartNewRun, and execute.replanAbandonRun, but the browser client defaults to /rpc, and web-host.ts attaches /rpc with createReadOnlyRpcHandlers, which filters write methods out. /rpc/driver only adds session driver methods, not these execute writes.
So this looks like a case where route/RPC tests can pass through injected handlers while the real web sidecar would return Method not found for the new buttons. Can we either expose these execute write methods on the intended web connection, or keep the web surface read-only and remove/disable the controls until that authority path exists?
|
Fixed: kept the web run observer read-only by removing replanning controls, web replanning RPC wrappers, and related invalidations. Focused web tests pass. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 5 total unresolved issues (including 3 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 928c972. Configure here.
Merge activity
|
4ffb084 to
82c49b5
Compare
f689244 to
e300f58
Compare
82c49b5 to
0486ec8
Compare


Stack Context
Stacked on PR #302 (
FE-1166: Add executor run environment policy). This PR makes executor runs easier to inspect and adds the first guarded replanning affordance on top of that evidence./
/runs
/run/<run_id>
What?
Observer / evidence readability
execute.runTraceIndexfor graph-node-to-run/slice traceability.Replanning / recovery
execute.replanRecommendation,execute.replanRegeneratePlan,execute.replanStartNewRun, andexecute.replanAbandonRun./runs/$runIdreplanning panel with diagnosis, allowed actions, web-callable action buttons, and disabled copy for executor-runtime-only retry.execute.replanRetryCurrentStepis intentionally not exposed over web RPC because it needsExecutionPortsand executor runtime/model context.Why?
Observability reads evidence; replanning acts on evidence. This PR keeps that split clear: the observer paths stay broad and passive, while replanning remains explicit, guarded, and evidence-preserving.
The run page now helps answer both questions: what happened, and what safe recovery action is available next.
How to run / inspect
/runs/$runIdto inspect readable worker/verify panels, grouped slice events, raw-log disclosures, and the replanning panel./spec/$specIdto seeREQ*/AC*graph nodes annotated with run badges that link back to the relevant run.execute.runTraceIndexandexecute.replanRecommendation.