Skip to content

FE-1050: Automate npm alpha publishing#351

Merged
kostandinang merged 2 commits into
nextfrom
ka/fe-1050-format-generated-release-pr
Jul 21, 2026
Merged

FE-1050: Automate npm alpha publishing#351
kostandinang merged 2 commits into
nextfrom
ka/fe-1050-format-generated-release-pr

Conversation

@kostandinang

@kostandinang kostandinang commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • format all files produced by the custom Changesets version command before the action commits its release PR
  • lock the version-command ordering with a release workflow contract test
  • record explicit non-release intent for this workflow-only correction

Test plan

  • npm test -- scripts/release-workflow.contract.test.mjs
  • isolated npm run version-packages followed by npm run fmt:check
  • git diff --check

Context

PR #350 exposed the gap: changeset version rewrote .changeset/pre.json in Changesets' valid JSON style, but the repository's oxfmt policy expects a different canonical layout. The Changesets action supports custom version scripts and includes all modifications they make, so formatting in version-packages fixes generation rather than patching each release PR.

kostandinang and others added 2 commits July 21, 2026 12:29
Co-authored-by: Cursor <cursoragent@cursor.com>
Run the repository formatter after Changesets versioning so automation-created release PRs satisfy the read-only format gate.

Co-authored-by: Cursor <cursoragent@cursor.com>

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kostandinang kostandinang changed the title chore: record release formatting fix FE-1050: Automate npm alpha publishing Jul 21, 2026
@kostandinang
kostandinang marked this pull request as ready for review July 21, 2026 10:31
@cursor

cursor Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Release automation script ordering only; no runtime, auth, or publish logic changes.

Overview
Fixes release PR noise from Changesets rewriting files (e.g. .changeset/pre.json) in a layout that fails oxfmt --check, as seen after PR #350.

The version-packages script is now changeset version && npm run fmt, so anything the custom version step touches is canonicalized before the Changesets action (version: npm run version-packages in release workflow) commits the release PR.

A release workflow contract test locks that script string, and an empty changeset documents that this change is workflow-only (no package version bump).

Reviewed by Cursor Bugbot for commit d200771. Bugbot is set up for automated code reviews on this repo. Configure here.

@kostandinang kostandinang self-assigned this Jul 21, 2026
@kostandinang
kostandinang merged commit 871d44b into next Jul 21, 2026
9 of 10 checks passed
@kostandinang
kostandinang deleted the ka/fe-1050-format-generated-release-pr branch July 21, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant