Skip to content

FE-1264: Block landing in comparison runs - #376

Merged
kostandinang merged 3 commits into
nextfrom
kostandin/fe-1264-block-landing-in-comparison-runs
Jul 24, 2026
Merged

FE-1264: Block landing in comparison runs#376
kostandinang merged 3 commits into
nextfrom
kostandin/fe-1264-block-landing-in-comparison-runs

Conversation

@kostandinang

@kostandinang kostandinang commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Why

Landing from an isolated execution comparison invalidates the attempt and can leave changes in the host workspace.

What

Comparison runtimes now omit /brunch:land and execute_land_preflight, and the landing handler refuses policy-disabled calls before inspection, confirmation, or mutation. Normal runtimes retain confirmation-gated landing.

How to test

  • npm run verify:full

@kostandinang kostandinang self-assigned this Jul 24, 2026
@kostandinang
kostandinang marked this pull request as ready for review July 24, 2026 09:32
@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches host-mutation landing paths and comparison runtime wiring; behavior is gated and well-tested, but incorrect policy defaults could block legitimate landings or leave a bypass in comparisons.

Overview
Isolated execution comparison runtimes can no longer land promoted work into the host workspace, so comparison attempts stay valid and the host is not mutated.

A new allowHostLanding policy (default on) threads through Pi extension options and execute-land registration. When it is false, registerBrunchExecuteLand skips registering /brunch:land and execute_land_preflight, and runBrunchLandCommand exits immediately with a warning—before preflight, git inspection, confirmation, or apply. Comparison launches set allowHostLanding: false alongside the existing comparisonIsolation restrictions (e.g. allowWebTools: false). Normal product runtimes are unchanged.

Tests cover policy-disabled command behavior, empty registration, and a Pi runtime integration asserting no landing command or preflight tool in comparison mode.

Reviewed by Cursor Bugbot for commit d589fab. Bugbot is set up for automated code reviews on this repo. Configure here.

@kostandinang
kostandinang merged commit 3a85266 into next Jul 24, 2026
7 checks passed
@kostandinang
kostandinang deleted the kostandin/fe-1264-block-landing-in-comparison-runs branch July 24, 2026 10:01
@hash-worker hash-worker Bot mentioned this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant