You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Landing from an isolated execution comparison invalidates the attempt and can leave changes in the host workspace.
What
Comparison runtimes now omit /brunch:land and execute_land_preflight, and the landing handler refuses policy-disabled calls before inspection, confirmation, or mutation. Normal runtimes retain confirmation-gated landing.
Medium Risk
Touches host-mutation landing paths and comparison runtime wiring; behavior is gated and well-tested, but incorrect policy defaults could block legitimate landings or leave a bypass in comparisons.
Overview Isolated execution comparison runtimes can no longer land promoted work into the host workspace, so comparison attempts stay valid and the host is not mutated.
A new allowHostLanding policy (default on) threads through Pi extension options and execute-land registration. When it is false, registerBrunchExecuteLand skips registering /brunch:land and execute_land_preflight, and runBrunchLandCommand exits immediately with a warning—before preflight, git inspection, confirmation, or apply. Comparison launches set allowHostLanding: false alongside the existing comparisonIsolation restrictions (e.g. allowWebTools: false). Normal product runtimes are unchanged.
Tests cover policy-disabled command behavior, empty registration, and a Pi runtime integration asserting no landing command or preflight tool in comparison mode.
Reviewed by Cursor Bugbot for commit d589fab. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Landing from an isolated execution comparison invalidates the attempt and can leave changes in the host workspace.
What
Comparison runtimes now omit
/brunch:landandexecute_land_preflight, and the landing handler refuses policy-disabled calls before inspection, confirmation, or mutation. Normal runtimes retain confirmation-gated landing.How to test
npm run verify:full