Skip to content

FE-1316: Audit current system authority and drift - #412

Open
lunelson wants to merge 3 commits into
ln/fe-1311-integrity-cleanupfrom
ln/fe-1316-system-authority-audit
Open

FE-1316: Audit current system authority and drift#412
lunelson wants to merge 3 commits into
ln/fe-1311-integrity-cleanupfrom
ln/fe-1316-system-authority-audit

Conversation

@lunelson

@lunelson lunelson commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Why

After a run of related work landed, this was a scheduled check-in: are we tracking every open thread correctly, and has anything drifted out of sync between what the docs say and what the code actually does? This is a review pass, not new product functionality.

What

  • Reviewed 13 areas touched by recent work for leftover dead behavior, doc/code drift, and follow-up work that had lost its owner.
  • Found and fixed one real, if small, product issue: outdated on-screen guidance text shown during a review step that no longer matched how corrections actually work.
  • Confirmed the surrounding executor, comparison, and tracing subsystems are each on track with their existing owners rather than silently stalled.
  • Opened two focused, scoped follow-ups instead of leaving loose ends: reconciling drifted internal documentation, and closing a gap in how we fingerprint automated test evidence (see the two PRs stacked above this one).

How to test

This is an audit/planning pass with one small text fix.

  1. npm run check passes.
  2. The two admitted follow-on issues (FE-1317, FE-1318) exist in Linear and are addressed by the PRs stacked on top of this one.

lunelson commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@lunelson lunelson changed the title FE-1316: Charter current-system reorientation audit FE-1316: Audit current system authority and drift Aug 7, 2026
@lunelson
lunelson marked this pull request as ready for review August 7, 2026 16:16
Copilot AI review requested due to automatic review settings August 7, 2026 16:16
@cursor

cursor Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Planning-archive updates plus prompt-guidance text and tests; no executor or capture logic changes in this diff.

Overview
FE-1316 system reorientation audit is recorded as complete in memory/PLAN.md and docs/archive/PLAN_HISTORY.md: thirteen post-cleanup concerns get evidence-backed dispositions, promoted work stays with existing owners, and the temporary audit ledger is removed. Two Next frontiers are added—canonical-document-reconciliation (normative doc drift from the inventory) and host-landing-oracle-identity (PTY inputs in the host-landing oracle pack hash)—with full frontier definitions and dependency-graph entries.

The only runtime change fixes stale present_digest prompt text that still told providers to use approve / request changes / reject on the continuation ask. Guidance now matches the landed flow: continued asks collect conversational free-text corrections, do not accept the digest for capture, and require a successor digest plus a separate ask with acceptsDigest to authorize capture. exchanges-extension.test.ts asserts the new strings and explicitly rejects the old tri-state wording.

Reviewed by Cursor Bugbot for commit 51f3e07. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a documentation/audit pass following FE-1316, tightening the structured-exchange “present_digest → ask” guidance to match the current conversational correction flow, and updating planning artifacts to record the audit closeout plus two newly admitted follow-on frontiers.

Changes:

  • Updated present_digest tool description/guidelines to reflect free-text correction continuations and the separate acceptsDigest capture step.
  • Adjusted extension tests to assert the new guidance and reject the deprecated approve/request-changes/reject phrasing.
  • Recorded FE-1316 closeout and admitted frontiers in memory/PLAN.md, with corresponding archival notes in docs/archive/PLAN_HISTORY.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/.pi/extensions/exchanges/present-digest.ts Updates the tool’s user-facing guidance to match the current correction + capture flow.
src/.pi/extensions/tests/exchanges-extension.test.ts Updates assertions to reflect the revised guidance strings and remove expectations for deprecated phrasing.
memory/PLAN.md Logs FE-1316 completion and adds definitions + sequencing entries for two new follow-on frontiers.
docs/archive/PLAN_HISTORY.md Archives FE-1316 closeout narrative and records the admitted follow-on frontiers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants