Merged
Conversation
vilkinsons
approved these changes
Jun 22, 2021
Member
|
Thanks, Valentino! Much appreciated. |
kube
added a commit
that referenced
this pull request
Apr 15, 2026
AI review fixes: - #10 Stacked data recomputed on every render — wrap data in useMemo keyed on revision/chartType/hiddenPlaces. The component opts out of React Compiler ("use no memo"), so without manual memoization the expensive buildStackedData ran on every playback frame even though Effect 3 only consumes it on revision changes - #11 Removed redundant store.length === 0 check inside the chart creation effect. The parent (SimulationTimelineContent) already gates on store.length === 0 and renders a "No simulation data" message, so UPlotChart only mounts when data exists. Comment clarifies the contract. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.