H-5331: Support CPU and Wall time profiling in benchmarks#7789
Draft
TimDiekmann wants to merge 4 commits intomainfrom
Draft
H-5331: Support CPU and Wall time profiling in benchmarks#7789TimDiekmann wants to merge 4 commits intomainfrom
TimDiekmann wants to merge 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7789 +/- ##
==========================================
- Coverage 54.71% 54.70% -0.01%
==========================================
Files 1085 1085
Lines 96195 96207 +12
Branches 4547 4553 +6
==========================================
Hits 52632 52632
- Misses 42976 42988 +12
Partials 587 587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Benchmarks don't finish, there is something going on which is not reproducible locally. Converting to draft. |
Member
|
How might the CodSpeed PR (#8204) interact with this open PR? @TimDiekmann @indietyp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
This implements CPU time profiling (using pprof) and Wall time profiling (using tracing spans). It can be hooked into the profiling by enabling them in the telemetry config.
🔍 What does this change?
tracing-flamefor three reasons:tracing-opentelemetry, which means that the resulting flame graph will be similar to the tracestracing-flameonly supports aio::Writeinterface but we want to collect them asynchronous in a dedicated thread using channels. While we could usewriteandflushto send messages, utilizing channels is easier, in particular because it allows us to use dedicated errorstracing-flamecreates a folded row for each enter/exit of a span resulting in a huge amount of data. It is enough to only generate a single row for flame graphs (we would need that for flame charts, but for that functionality, we have proper tracing)pprofimplementationBoth implementation can be separately disabled.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
This is currently disabled in production because:
std::threadapproach overtokio::task)