BE-249: Remove dependence on nightly allocator api in dependencies and modularize heap #8193

indietyp · 2025-12-17T18:38:05Z

🌟 What is the purpose of this PR?

Update oxc from 0.95.0 to 0.103.0 and modernize the heap module to use allocator-api2 for better compatibility with the Rust ecosystem.

🔍 What does this change?

Remove allocator API feature from oxc
Refactors the heap module to rely on bumpalo allocator-api2 for arena allocations
Adds new traits for allocator-aware operations:
- CloneIn / TryCloneIn for cloning into arenas
- FromIn / IntoIn for converting with allocators
- FromIteratorIn / CollectIn for collecting iterators
- TransferInto / TryTransferInto for copying slices/strings
Replaces direct heap allocation methods with more idiomatic alternatives
Updates code to use the new traits throughout the codebase

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

do not affect the execution graph

🛡 What tests cover this?

Existing tests cover the functionality
The heap module has new unit tests for the added traits

cursor · 2025-12-17T18:38:12Z

PR Summary

Replaces custom heap APIs with allocator-api2-backed arena (Heap/Scratch) and allocator-aware traits, updates type inference and AST/parser to use Box/Vec *_in APIs and CollectIn, and adjusts dependencies (allocator-api2, bumpalo, oxc).

Core (heap):
- Introduces bumpalo-backed allocator wrapper using allocator-api2; Heap refactored and Scratch added for temporary allocations.
- Adds allocator-aware traits: CloneIn/TryCloneIn, FromIn/IntoIn, FromIteratorIn/CollectIn, TransferInto/TryTransferInto.
- Implements alloc::Allocator for Heap and Scratch; interned strings now use TransferInto.
Type Inference:
- Replaces Bump with heap::Scratch; APIs accept Scratch; internal passes updated accordingly.
AST/HIR/Parser:
- Switches to Box::new_in, Vec::new_in/with_capacity_in, and CollectIn across lowering, reification, and J-Expr parsing.
- Removes use of custom heap.vec/boxed helpers.
Dependencies/Config:
- Adds allocator-api2, enables bumpalo with allocator-api2; removes oxc allocator feature; minor crate version bumps.

^{Written by Cursor Bugbot for commit 81277ff. This will update automatically on new commits. Configure here.}

indietyp · 2025-12-17T18:38:24Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-12-17T18:42:02Z

Codecov Report

❌ Patch coverage is 82.60000% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.79%. Comparing base (93c0279) to head (81277ff).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
libs/@local/hashql/core/src/heap/clone.rs	18.60%	35 Missing ⚠️
libs/@local/hashql/core/src/heap/transfer.rs	72.46%	19 Missing ⚠️
libs/@local/hashql/core/src/heap/allocator.rs	82.08%	12 Missing ⚠️
libs/@local/hashql/core/src/heap/mod.rs	80.00%	10 Missing ⚠️
libs/@local/hashql/core/src/heap/scratch.rs	64.28%	10 Missing ⚠️
...ashql/syntax-jexpr/src/parser/string/combinator.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8193      +/-   ##
==========================================
+ Coverage   58.44%   58.79%   +0.35%     
==========================================
  Files        1181     1188       +7     
  Lines      111529   112204     +675     
  Branches     5012     5010       -2     
==========================================
+ Hits        65180    65974     +794     
+ Misses      45592    45472     -120     
- Partials      757      758       +1

Flag	Coverage Δ
apps.hash-ai-worker-ts	`1.32% <ø> (ø)`
apps.hash-api	`0.00% <ø> (ø)`
blockprotocol.type-system	`40.84% <ø> (ø)`
local.claude-hooks	`0.00% <ø> (ø)`
local.harpc-client	`51.24% <ø> (ø)`
local.hash-graph-sdk	`10.88% <ø> (ø)`
local.hash-isomorphic-utils	`0.00% <ø> (ø)`
rust.antsi	`0.00% <ø> (ø)`
rust.error-stack	`90.88% <ø> (ø)`
rust.harpc-codec	`84.70% <ø> (ø)`
rust.harpc-net	`96.14% <ø> (-0.07%)`	⬇️
rust.harpc-tower	`66.80% <ø> (ø)`
rust.harpc-types	`0.00% <ø> (ø)`
rust.harpc-wire-protocol	`92.23% <ø> (ø)`
rust.hash-codec	`72.76% <ø> (ø)`
rust.hash-graph-api	`2.89% <ø> (ø)`
rust.hash-graph-authorization	`62.47% <ø> (ø)`
rust.hash-graph-postgres-store	`25.61% <ø> (ø)`
rust.hash-graph-store	`30.54% <ø> (ø)`
rust.hash-graph-temporal-versioning	`47.95% <ø> (ø)`
rust.hash-graph-types	`0.00% <ø> (ø)`
rust.hash-graph-validation	`83.45% <ø> (ø)`
rust.hashql-ast	`87.25% <100.00%> (+<0.01%)`	⬆️
rust.hashql-compiletest	`46.65% <ø> (ø)`
rust.hashql-core	`82.34% <78.60%> (+0.13%)`	⬆️
rust.hashql-diagnostics	`72.43% <ø> (ø)`
rust.hashql-eval	`68.54% <ø> (ø)`
rust.hashql-hir	`89.10% <100.00%> (ø)`
rust.hashql-mir	`88.77% <ø> (+2.01%)`	⬆️
rust.hashql-syntax-jexpr	`94.05% <98.43%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

libs/@local/hashql/core/src/heap/clone.rs

indietyp · 2025-12-17T18:45:34Z

We still use the allocator API inside of hashbrown, draft until fixed.

libs/@local/hashql/core/src/heap/mod.rs

indietyp · 2025-12-17T19:59:27Z

The change now is that when we update oxc we just need to downgrade hashbrown to make sure that we have two different libraries (like we already do) but we no longer need to do the allocator trick, because we no longer depend on bumpalo doing this for us.

github-actions · 2025-12-19T01:11:42Z

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 2002	$$26.6 \mathrm{ms} \pm 207 \mathrm{μs}\left({\color{lightgreen}-10.484 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$3.21 \mathrm{ms} \pm 17.1 \mathrm{μs}\left({\color{gray}-2.288 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 1001	$$11.8 \mathrm{ms} \pm 75.1 \mathrm{μs}\left({\color{lightgreen}-10.632 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 3314	$$41.5 \mathrm{ms} \pm 293 \mathrm{μs}\left({\color{gray}-3.496 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$13.9 \mathrm{ms} \pm 78.5 \mathrm{μs}\left({\color{gray}-3.500 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 1526	$$23.3 \mathrm{ms} \pm 150 \mathrm{μs}\left({\color{lightgreen}-6.096 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 2078	$$26.6 \mathrm{ms} \pm 141 \mathrm{μs}\left({\color{lightgreen}-46.374 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$3.63 \mathrm{ms} \pm 19.0 \mathrm{μs}\left({\color{lightgreen}-83.343 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 1033	$$11.0 \mathrm{ms} \pm 62.3 \mathrm{μs}\left({\color{lightgreen}-67.193 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_medium

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 102	$$3.65 \mathrm{ms} \pm 17.1 \mathrm{μs}\left({\color{gray}-1.364 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.86 \mathrm{ms} \pm 16.1 \mathrm{μs}\left({\color{gray}1.49 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 51	$$3.17 \mathrm{ms} \pm 14.5 \mathrm{μs}\left({\color{gray}-0.700 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 269	$$4.97 \mathrm{ms} \pm 25.4 \mathrm{μs}\left({\color{gray}0.501 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$3.37 \mathrm{ms} \pm 13.8 \mathrm{μs}\left({\color{gray}-0.772 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 107	$$3.95 \mathrm{ms} \pm 27.7 \mathrm{μs}\left({\color{gray}-0.282 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 133	$$4.27 \mathrm{ms} \pm 23.7 \mathrm{μs}\left({\color{gray}-0.377 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$3.31 \mathrm{ms} \pm 12.5 \mathrm{μs}\left({\color{gray}-0.952 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 63	$$3.89 \mathrm{ms} \pm 20.2 \mathrm{μs}\left({\color{gray}0.892 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_none

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 2	$$2.55 \mathrm{ms} \pm 12.1 \mathrm{μs}\left({\color{red}6.70 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.50 \mathrm{ms} \pm 14.3 \mathrm{μs}\left({\color{red}6.27 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 1	$$2.59 \mathrm{ms} \pm 11.5 \mathrm{μs}\left({\color{red}6.34 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 8	$$2.78 \mathrm{ms} \pm 12.6 \mathrm{μs}\left({\color{gray}4.53 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$2.67 \mathrm{ms} \pm 10.9 \mathrm{μs}\left({\color{red}6.22 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 3	$$2.88 \mathrm{ms} \pm 14.2 \mathrm{μs}\left({\color{red}5.64 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_small

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 52	$$2.93 \mathrm{ms} \pm 15.6 \mathrm{μs}\left({\color{gray}3.86 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.61 \mathrm{ms} \pm 11.4 \mathrm{μs}\left({\color{red}6.47 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 25	$$2.79 \mathrm{ms} \pm 12.2 \mathrm{μs}\left({\color{red}5.65 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 94	$$3.29 \mathrm{ms} \pm 16.3 \mathrm{μs}\left({\color{red}5.31 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$2.85 \mathrm{ms} \pm 12.9 \mathrm{μs}\left({\color{red}5.30 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 26	$$3.06 \mathrm{ms} \pm 13.6 \mathrm{μs}\left({\color{gray}4.14 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 66	$$3.21 \mathrm{ms} \pm 17.5 \mathrm{μs}\left({\color{gray}4.17 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$2.83 \mathrm{ms} \pm 13.1 \mathrm{μs}\left({\color{red}6.09 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 29	$$3.11 \mathrm{ms} \pm 18.8 \mathrm{μs}\left({\color{red}7.05 \mathrm{\%}}\right) $$	Flame Graph

read_scaling_complete

Function	Value	Mean	Flame graphs
entity_by_id;one_depth	1 entities	$$39.0 \mathrm{ms} \pm 142 \mathrm{μs}\left({\color{gray}-2.894 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	10 entities	$$75.2 \mathrm{ms} \pm 304 \mathrm{μs}\left({\color{gray}-4.725 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	25 entities	$$43.7 \mathrm{ms} \pm 179 \mathrm{μs}\left({\color{gray}-3.259 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	5 entities	$$45.2 \mathrm{ms} \pm 189 \mathrm{μs}\left({\color{gray}-3.665 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	50 entities	$$55.1 \mathrm{ms} \pm 322 \mathrm{μs}\left({\color{gray}-2.536 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	1 entities	$$40.5 \mathrm{ms} \pm 154 \mathrm{μs}\left({\color{gray}-4.886 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	10 entities	$$412 \mathrm{ms} \pm 824 \mathrm{μs}\left({\color{gray}-2.009 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	25 entities	$$94.0 \mathrm{ms} \pm 453 \mathrm{μs}\left({\color{gray}-2.162 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	5 entities	$$84.2 \mathrm{ms} \pm 350 \mathrm{μs}\left({\color{gray}-2.366 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	50 entities	$$279 \mathrm{ms} \pm 622 \mathrm{μs}\left({\color{gray}-2.240 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	1 entities	$$14.6 \mathrm{ms} \pm 66.0 \mathrm{μs}\left({\color{lightgreen}-5.591 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	10 entities	$$15.0 \mathrm{ms} \pm 76.1 \mathrm{μs}\left({\color{gray}-0.479 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	25 entities	$$15.2 \mathrm{ms} \pm 73.7 \mathrm{μs}\left({\color{gray}-4.127 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	5 entities	$$14.9 \mathrm{ms} \pm 64.1 \mathrm{μs}\left({\color{gray}-2.137 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	50 entities	$$18.4 \mathrm{ms} \pm 101 \mathrm{μs}\left({\color{gray}-0.308 \mathrm{\%}}\right) $$	Flame Graph

read_scaling_linkless

Function	Value	Mean	Flame graphs
entity_by_id	1 entities	$$14.9 \mathrm{ms} \pm 90.7 \mathrm{μs}\left({\color{gray}-2.767 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10 entities	$$15.0 \mathrm{ms} \pm 64.8 \mathrm{μs}\left({\color{gray}0.809 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	100 entities	$$14.9 \mathrm{ms} \pm 69.5 \mathrm{μs}\left({\color{gray}3.19 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1000 entities	$$15.4 \mathrm{ms} \pm 84.9 \mathrm{μs}\left({\color{gray}3.17 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10000 entities	$$22.0 \mathrm{ms} \pm 134 \mathrm{μs}\left({\color{gray}-2.390 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity

Function	Value	Mean	Flame graphs
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/block/v/1`	$$29.6 \mathrm{ms} \pm 295 \mathrm{μs}\left({\color{gray}-0.617 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/book/v/1`	$$29.3 \mathrm{ms} \pm 285 \mathrm{μs}\left({\color{gray}-4.860 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/building/v/1`	$$28.9 \mathrm{ms} \pm 265 \mathrm{μs}\left({\color{gray}-1.575 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/organization/v/1`	$$29.4 \mathrm{ms} \pm 262 \mathrm{μs}\left({\color{gray}-4.965 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/page/v/2`	$$29.5 \mathrm{ms} \pm 267 \mathrm{μs}\left({\color{gray}-3.496 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/person/v/1`	$$29.8 \mathrm{ms} \pm 345 \mathrm{μs}\left({\color{gray}-1.079 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/playlist/v/1`	$$29.1 \mathrm{ms} \pm 259 \mathrm{μs}\left({\color{gray}-2.622 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/song/v/1`	$$29.7 \mathrm{ms} \pm 234 \mathrm{μs}\left({\color{gray}-1.973 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1`	$$28.9 \mathrm{ms} \pm 252 \mathrm{μs}\left({\color{gray}-4.453 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity_type

Function	Value	Mean	Flame graphs
get_entity_type_by_id	Account ID: `bf5a9ef5-dc3b-43cf-a291-6210c0321eba`	$$8.22 \mathrm{ms} \pm 45.3 \mathrm{μs}\left({\color{gray}1.99 \mathrm{\%}}\right) $$	Flame Graph

representative_read_multiple_entities

Function	Value	Mean	Flame graphs
entity_by_property	traversal_paths=0	0	$$47.2 \mathrm{ms} \pm 245 \mathrm{μs}\left({\color{gray}0.247 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=255	1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true	$$94.7 \mathrm{ms} \pm 363 \mathrm{μs}\left({\color{gray}-1.328 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false	$$53.7 \mathrm{ms} \pm 344 \mathrm{μs}\left({\color{gray}0.402 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true	$$60.6 \mathrm{ms} \pm 312 \mathrm{μs}\left({\color{gray}-0.713 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true	$$68.7 \mathrm{ms} \pm 306 \mathrm{μs}\left({\color{gray}0.109 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true	$$75.4 \mathrm{ms} \pm 357 \mathrm{μs}\left({\color{gray}-2.382 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=0	0	$$51.5 \mathrm{ms} \pm 352 \mathrm{μs}\left({\color{gray}-2.825 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=255	1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true	$$77.0 \mathrm{ms} \pm 399 \mathrm{μs}\left({\color{gray}-1.319 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false	$$56.3 \mathrm{ms} \pm 320 \mathrm{μs}\left({\color{gray}-3.588 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true	$$63.9 \mathrm{ms} \pm 282 \mathrm{μs}\left({\color{gray}-4.345 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true	$$65.7 \mathrm{ms} \pm 250 \mathrm{μs}\left({\color{lightgreen}-5.661 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true	$$66.3 \mathrm{ms} \pm 331 \mathrm{μs}\left({\color{gray}-4.404 \mathrm{\%}}\right) $$

scenarios

Function	Value	Mean	Flame graphs
full_test	query-limited	$$144 \mathrm{ms} \pm 492 \mathrm{μs}\left({\color{red}13.1 \mathrm{\%}}\right) $$	Flame Graph
full_test	query-unlimited	$$138 \mathrm{ms} \pm 461 \mathrm{μs}\left({\color{red}8.63 \mathrm{\%}}\right) $$	Flame Graph
linked_queries	query-limited	$$40.5 \mathrm{ms} \pm 170 \mathrm{μs}\left({\color{lightgreen}-33.175 \mathrm{\%}}\right) $$	Flame Graph
linked_queries	query-unlimited	$$599 \mathrm{ms} \pm 885 \mathrm{μs}\left({\color{gray}1.80 \mathrm{\%}}\right) $$	Flame Graph

libs/@local/hashql/syntax-jexpr/src/parser/array/mod.rs

TimDiekmann

Do we use alloc::alloc::alloc now? 🙃

Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/20373065214

indietyp added 11 commits December 17, 2025 10:25

chore: checkpoint

cad4346

feat: move over to trait based allocator

1543725

chore: try to alloc

9ef7ea0

feat: move to new API

ff089be

chore: checkpoint

57b601a

chore: checkpoint

0a9b5c7

chore: checkpoint

abdb35c

chore: docs

d65fad8

chore: newline

ce98478

chore: imports

dd23bf6

chore: expect reason

2d4bf11

graphite-app bot assigned indietyp Dec 17, 2025

github-actions bot added area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Dec 17, 2025

fix: allocator api dependency placement

cd82b51

vercel bot deployed to Preview – petrinaut December 17, 2025 18:43 View deployment

indietyp marked this pull request as draft December 17, 2025 18:44

cursor bot reviewed Dec 17, 2025

View reviewed changes

libs/@local/hashql/core/src/heap/clone.rs Show resolved Hide resolved

graphite-app bot reviewed Dec 17, 2025

View reviewed changes

libs/@local/hashql/core/src/heap/mod.rs Outdated Show resolved Hide resolved

libs/@local/hashql/core/src/heap/mod.rs Outdated Show resolved Hide resolved

vercel bot deployed to Preview – hash December 17, 2025 18:51 View deployment

chore: clone into properly

8f6fd49

indietyp marked this pull request as ready for review December 17, 2025 19:59

vercel bot deployed to Preview – hashdotdesign December 17, 2025 20:02 View deployment

vercel bot deployed to Preview – petrinaut December 17, 2025 20:03 View deployment

vercel bot deployed to Preview – hash December 19, 2025 00:20 View deployment

indietyp added 2 commits December 19, 2025 09:34

fix: skill-rules file validation

035365a

fix: suggestions from code review

bc68f12

indietyp force-pushed the bm/be-249-hashql-remove-dependence-on-bumpalo-allocator_api-feature branch from 7f9110d to b482246 Compare December 19, 2025 08:41

vercel bot deployed to Preview – petrinaut December 19, 2025 08:46 View deployment

cursor bot reviewed Dec 19, 2025

View reviewed changes

libs/@local/hashql/syntax-jexpr/src/parser/array/mod.rs Outdated Show resolved Hide resolved

fix: YAML validity

79f1d6e

indietyp force-pushed the bm/be-249-hashql-remove-dependence-on-bumpalo-allocator_api-feature branch from b482246 to b3ba558 Compare December 19, 2025 08:54

vercel bot deployed to Preview – petrinaut December 19, 2025 08:59 View deployment

vercel bot deployed to Preview – hash December 19, 2025 09:05 View deployment

indietyp added 2 commits December 19, 2025 10:05

fix: package-json

53df9af

fix: move instead of clone

81277ff

indietyp force-pushed the bm/be-249-hashql-remove-dependence-on-bumpalo-allocator_api-feature branch from b3ba558 to a49c228 Compare December 19, 2025 09:13

vercel bot deployed to Preview – petrinaut December 19, 2025 09:18 View deployment

vercel bot deployed to Preview – hash December 19, 2025 09:26 View deployment

TimDiekmann previously approved these changes Dec 19, 2025

View reviewed changes

indietyp added 2 commits December 19, 2025 15:31

feat: remove 🇩🇪

688a73a

feat: remove bumpalo from type inference

a9cda70

indietyp force-pushed the bm/be-249-hashql-remove-dependence-on-bumpalo-allocator_api-feature branch from a49c228 to 81277ff Compare December 19, 2025 14:31

TimDiekmann approved these changes Dec 19, 2025

View reviewed changes

vercel bot deployed to Preview – petrinaut December 19, 2025 14:36 View deployment

vercel bot deployed to Preview – hash December 19, 2025 14:45 View deployment

Base automatically changed from bm/h-5880-adjust-skills-to-be-in-line-with-new-open-standard to main December 19, 2025 15:16

indietyp added this pull request to the merge queue Dec 19, 2025

graphite-app bot requested a review from a team December 19, 2025 15:17

Merged via the queue into main with commit 067d656 Dec 19, 2025
165 of 184 checks passed

indietyp deleted the bm/be-249-hashql-remove-dependence-on-bumpalo-allocator_api-feature branch December 19, 2025 15:36

BE-249: Remove dependence on nightly allocator api in dependencies and modularize heap #8193

BE-249: Remove dependence on nightly allocator api in dependencies and modularize heap #8193

Uh oh!

Conversation

indietyp commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌟 What is the purpose of this PR?

🔍 What does this change?

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

📜 Does this require a change to the docs?

🕸️ Does this require a change to the Turbo Graph?

🛡 What tests cover this?

Uh oh!

cursor bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

indietyp commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

indietyp commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

indietyp commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 19, 2025

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

policy_resolution_medium

policy_resolution_none

policy_resolution_small

read_scaling_complete

read_scaling_linkless

representative_read_entity

representative_read_entity_type

representative_read_multiple_entities

scenarios

Uh oh!

Uh oh!

TimDiekmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

indietyp commented Dec 17, 2025 •

edited

Loading

cursor bot commented Dec 17, 2025 •

edited

Loading

indietyp commented Dec 17, 2025 •

edited

Loading

codecov bot commented Dec 17, 2025 •

edited

Loading