-
Notifications
You must be signed in to change notification settings - Fork 122
H-6479: markdownlint ignore Cursor plan documents #8733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,9 +1,13 @@ | ||||||||||||||||||||||||||
| # Block Protocol Type System | ||||||||||||||||||||||||||
| # SemType (Block Protocol Type System) | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| This crate implements the Block Protocol type system in Rust. It provides the foundation for defining, validating, and working with typed data in the HASH ecosystem. For details on the type system design, see the [Block Protocol Type System RFC](https://github.com/blockprotocol/blockprotocol/blob/main/rfcs/text/0352-graph-type-system.md). | ||||||||||||||||||||||||||
| This crate implements the SemType specification in Rust. It provides the foundation for defining, validating, and working with typed data in the HASH ecosystem. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| **The public, canonical specification of the type system is published at [semtype.org/spec](https://semtype.org/spec).** This Rust crate is the reference implementation; the spec is kept in sync with it by hand, so changes to the type system here should be reflected at `semtype.org/spec`. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| The corresponding TypeScript implementation can be found in the [`@blockprotocol/type-system`](../typescript) package. This crate is used to generate the TypeScript typings from the Rust implementation. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| The predecessor to SemType was the "Block Protocol type system". For details on its (now deprecated) design, see the original [Block Protocol Type System RFC](https://github.com/blockprotocol/blockprotocol/blob/main/rfcs/text/0352-graph-type-system.md). | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ## Overview | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| The Block Protocol Type System defines a structured approach to typing data. It enables: | ||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now that the README introduces SemType, this line still says βThe Block Protocol Type System definesβ¦β, which reads inconsistent. Consider updating it to βSemTypeβ (or just βthe type systemβ) to avoid mixed terminology. Severity: low π€ Was this useful? React with π or π, or π if it prevented an incident/outage.
Comment on lines
+9
to
13
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistency in rebranding: The unchanged line 13 still refers to "The Block Protocol Type System" in the Overview section, but the PR rebrand this to "SemType" (with Block Protocol being the predecessor). This creates confusing documentation where:
Fix: Update line 13 to reflect the new branding: SemType defines a structured approach to typing data. It enables:
Suggested change
Spotted by Graphite |
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR template/process note: the PR description has every βpublishable library/docs/turbo graphβ checkbox ticked, which can be misleading for release/docs checks. Consider leaving only the applicable option(s) checked and removing the rest per the template instructions.
Severity: low
π€ Was this useful? React with π or π, or π if it prevented an incident/outage.