An update that does not request any fields fails

[harendra-kumar]

A pure update that does not request any fields in the results must be allowed. The following query fails to parse:

{SetResource(id:"1",resource:{resAge:20,resGender:"m"}){}}

[jml]

Huh, interesting. I think you’re right, but can you point to relevant bit of the spec? Will make it easier to fix.

…

On Thu, 1 Mar 2018 at 04:07, Harendra Kumar ***@***.***> wrote: A pure update that does not request any fields in the results must be allowed. The following query fails to parse: {SetResource(id:"1",resource:{resAge:20,resGender:"m"}){}} — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#174>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHq6rYEf9D1fB2LQ7liOSttdhG3bZGRks5tZ2YCgaJpZM4SXsOF> .

[harendra-kumar]

I did not look at the spec. I just thought it makes sense and assumed it. I will update if I happen to take a look at the spec.

[harendra-kumar]

yeah, I was confused whether to use {} or just omit it for an empty request, that must get clarified by the spec.

[jml]

AFAICT, the GraphQL spec does not prohibit empty selection sets, so this is a valid bug. However, it also does not say how to handle them, so fixing involves some decision making.

Things that you or someone else can do to help fix this bug:

• review the spec to see if I've missed something
• identify what other (esp. Facebook-authored) GraphQL servers do with this
  • include steps to reproduce, versions, etc.
• write a test that would pass if this bug were fixed