Bump QuickCheck + base-orphan; faster test compilation #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original property testing used a single file to specify all
property tests, which caused compilation issues and intermittent
Travis CI build failures. This commit breaks the Properties file into
multiple files to make it faster to compile.
| Properties | GHC | QuickCheck | Clean build/test | properties build/test |
|-------------+-------+------------+-----------------------+-----------------------|
| single file | 8.4.4 | 2.11.3 | 3m48s / 5m56s / 1m33s | 1m42s / 1m58s / 0m31s |
| | | 2.12.6.1 | 3m27s / 5m42s / 0m58s | 1m45s / 2m2s / 0m33s |
|-------------+-------+------------+-----------------------+-----------------------|
| multi-file | 8.4.4 | 2.11.3 | 2m19s / 4m26s / 0m37s | 0m35s / 0m44s / 0m9s |
| | | 2.12.6.1 | 2m20s / 4m26s / 0m37s | 0m36s / 0m45s / 0m10s |
(times are in real, user, and sys time)
Collaborator
|
Thanks! |
Contributor
Author
|
Thanks for merging this. It would be great to get a Hackage release of this. It looks like one of the trustees bumped the base-orphans version allowing GHC 8.6, but the QuickCheck < 2.12 restriction is creating a lot of issues with other packages and transitive dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upper bounds for QuickCheck and base-orphan are bumped (similar to #676) but additionally the properties tests are broken into multiple files to speed up compilation and hopefully avoid Travis CI failures.
The discussion of #676 indicated that QuickCheck 2.12 was causing significantly slower compilation times, but local testing for me showed little difference between 2.12.6.1 and 2.11.3 (see the data in the commit comment for commit 3f553c4), but breaking the tests into multiple files improved compilation times for both QuickCheck versions. All tests pass for all configurations, so there is no indication that there is any validity regression involved.
This commit does not change the API nor does it add any new features, so it should only require a minor version bump (C of A.B.C) per the PVP.