final fixups to sdist check

[geekosaur]

validated on 3.12 branch and applied in backport of #10448; this brings the fixes up to master

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). actually taken from a backport!

[ulysses4ever]

Looks plausible...

[geekosaur]

It led to the first actual success of the check on 3.12 branch where it originated (as a fixup to #10477), so I'm fairly confident that it's now working properly.

[geekosaur]

Not needed for 3.14 release, but we probably want it in the tree before we make any later 3.14 releases so we can verify that they don't break compatibility with the bundled Cabal in 9.12.1. Note that the backport will need Depends-on: #10477.

[Kleidukos]

@geekosaur I believe this can go in. I'll start the process of producing the binaries after it's merged.

[geekosaur]

There's no reason it can't, it just won't do anything until post-release and even then it'll only affect CI, so I don't see much point to it slowing the release.

[geekosaur]

@mergify backport 3.14

[mergify]

backport 3.14

✅ Backports have been created

• #10649 Backport #10478: final fixups to sdist check has been created for branch 3.14

[geekosaur]

@mergify backport 3.14.1.1

[mergify]

backport 3.14.1.1

✅ Backports have been created

• #10674 Backport #10478: final fixups to sdist check has been created for branch 3.14.1.1

[geekosaur]

turns out we need it because I added the branch protection rule… after the release. which wouldn't have been a problem except for this emergency release.