Skip to content

Require Applicative (g s) as a superclass of FieldGrammar#11821

Merged
mergify[bot] merged 1 commit into
masterfrom
require-applicative-for-FieldGrammar
May 17, 2026
Merged

Require Applicative (g s) as a superclass of FieldGrammar#11821
mergify[bot] merged 1 commit into
masterfrom
require-applicative-for-FieldGrammar

Conversation

@Bodigrim
Copy link
Copy Markdown
Collaborator

@Bodigrim Bodigrim commented May 12, 2026

I think we can finally act on the old TODO, cutting a bit of boilerplate.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

Comment thread Cabal-syntax/src/Distribution/FieldGrammar/Class.hs
@Bodigrim Bodigrim force-pushed the require-applicative-for-FieldGrammar branch from 17840c4 to cbfdc42 Compare May 14, 2026 21:19
@Bodigrim Bodigrim added the merge me Tell Mergify Bot to merge label May 14, 2026
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label May 14, 2026
Thus acting on the old todo, which helps a little bit with boilerplate.
@Bodigrim Bodigrim force-pushed the require-applicative-for-FieldGrammar branch from cbfdc42 to 4e2cbec Compare May 15, 2026 20:59
@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels May 17, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 17, 2026

Merge Queue Status

This pull request spent 1 hour 49 minutes 1 second in the queue, including 1 hour 38 minutes 2 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify Bot added a commit that referenced this pull request May 17, 2026
@mergify mergify Bot merged commit 07b96a2 into master May 17, 2026
139 checks passed
@mergify mergify Bot deleted the require-applicative-for-FieldGrammar branch May 17, 2026 22:50
@mergify mergify Bot removed the queued label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants