Skip to content

Fix #7582: add Ord to the derived instances of SymbolicPath - #7585

Merged
Mikolaj merged 2 commits into
haskell:masterfrom
andreasabel:issue7582
Aug 30, 2021
Merged

Fix #7582: add Ord to the derived instances of SymbolicPath#7585
Mikolaj merged 2 commits into
haskell:masterfrom
andreasabel:issue7582

Conversation

@andreasabel

Copy link
Copy Markdown
Member

Fix #7582: add Ord to the derived instances of SymbolicPath.

  • Tested by checking compilation.
  • Given the granularity of the changelog, this change is below the threshold.

Please include the following checklist in your PR:

@Mikolaj Mikolaj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, I fully expected I lied that it's going to be a one-liner. @phadej: is that all you need?

@phadej

phadej commented Aug 30, 2021

Copy link
Copy Markdown
Collaborator

@Mikolaj yes. You'll make me very happy if you'll be able to squeeze that into Cabal-3.6.1.0 and that into GHC-9.2, but I'll probably survive even if it doesn't make there.

@Mikolaj

Mikolaj commented Aug 30, 2021

Copy link
Copy Markdown
Member

I will try squeezing. Not sure about GHC-9.2, you'd need to ask them hairy GHC haxors.

@phadej

phadej commented Aug 30, 2021

Copy link
Copy Markdown
Collaborator

It will be fine if it's bundled with GHC-9.2.2 (I doubt 9.2.1 will be the last in series), i.e. if you make Cabal-3.6.1 release once it accumulates enough backports and before GHC-9.2.2

@Mikolaj
Mikolaj merged commit 5b941fa into haskell:master Aug 30, 2021
@Mikolaj

Mikolaj commented Aug 30, 2021

Copy link
Copy Markdown
Member

Sounds plausible.

@Mergifyio: backport 3.6

@Mikolaj

Mikolaj commented Aug 30, 2021

Copy link
Copy Markdown
Member

Doh.

@Mergifyio backport 3.6

@mergify

mergify Bot commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Command backport 3.6: success

Backports have been created

Mikolaj pushed a commit that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Ord (SymbolicPath a b) instance

3 participants