-
Notifications
You must be signed in to change notification settings - Fork 235
Hide instances by default (#698) #700
Conversation
|
I think this makes class heavy modules easier to browse, thank you. As in the other PR yoi need to update the tests. |
|
Is there a command to update the tests? |
|
Yes, you can use the accept flag: |
|
Works like a charm. |
|
Is there anything holding this PR back? Really looking forward to this change! |
|
Why was this closed? |
|
This PR was closed accidentally, see this comment for how to reopen. |
|
Thanks for the pointer! I've changed the target branch to |
|
@Lysxia If you tried the EDIT button, and you looked for a "reopon" button when you add a comment, then I'm not sure. You could try adding another (pointless) commit to this PR, or create a new PR that references this one for context. I don't have admin permissions on this repo, but perhaps someone who does could reopen it? But Googling a bit, I get the impression that GitHub is restrictive when it comes to reopening PRs, at least if they've been merged (not the case here). So if you can't reopen it, I doubt anyone else can. |
|
Indeed the reopen button is disabled with the message "the hide-instances branch was force-pushed or recreated". All the closed PRs will have to be rebased and resubmitted I think? |
|
I might have been available if I didn't force push first. Reopened in #823. |
Fixes #698.