Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Conversation

@Lysxia
Copy link
Contributor

@Lysxia Lysxia commented Nov 10, 2017

Fixes #698.

@alexbiehl
Copy link
Member

I think this makes class heavy modules easier to browse, thank you. As in the other PR yoi need to update the tests.

@Lysxia
Copy link
Contributor Author

Lysxia commented Nov 10, 2017

Is there a command to update the tests?

@alexbiehl
Copy link
Member

Yes, you can use the accept flag: html-test -a should do the trick!

@Lysxia
Copy link
Contributor Author

Lysxia commented Nov 10, 2017

Works like a charm.

@ntc2
Copy link
Contributor

ntc2 commented Apr 5, 2018

Is there anything holding this PR back? Really looking forward to this change!

@alexbiehl alexbiehl closed this May 9, 2018
@Lysxia
Copy link
Contributor Author

Lysxia commented May 9, 2018

Why was this closed?

@ntc2
Copy link
Contributor

ntc2 commented May 9, 2018

This PR was closed accidentally, see this comment for how to reopen.

@Lysxia Lysxia changed the base branch from master to ghc-8.4 May 9, 2018 18:13
@Lysxia
Copy link
Contributor Author

Lysxia commented May 9, 2018

Thanks for the pointer! I've changed the target branch to ghc-8.4 but I can't see the option to reopen the PR.

@ntc2
Copy link
Contributor

ntc2 commented May 9, 2018

@Lysxia If you tried the EDIT button, and you looked for a "reopon" button when you add a comment, then I'm not sure. You could try adding another (pointless) commit to this PR, or create a new PR that references this one for context.

I don't have admin permissions on this repo, but perhaps someone who does could reopen it? But Googling a bit, I get the impression that GitHub is restrictive when it comes to reopening PRs, at least if they've been merged (not the case here). So if you can't reopen it, I doubt anyone else can.

@gbaz
Copy link
Contributor

gbaz commented May 10, 2018

Indeed the reopen button is disabled with the message "the hide-instances branch was force-pushed or recreated". All the closed PRs will have to be rebased and resubmitted I think?

@Lysxia
Copy link
Contributor Author

Lysxia commented May 10, 2018

I might have been available if I didn't force push first. Reopened in #823.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants