This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Dead code-paths in Hi Haddock#910
Merged
sjakobi merged 2 commits intohaskell:wip/hi-haddockfrom Aug 20, 2018
Merged
Conversation
Removing this code has no impact on the output.
sjakobi
reviewed
Aug 20, 2018
Member
sjakobi
left a comment
sjakobi
left a comment
There was a problem hiding this comment.
Thanks! :)
It's quite clear to me that this is dead code which can safely be removed.
Can you remove the DeclMap alias too?
I think we should also remove the Maps alias and let availExportItem take only those arguments that it actually needs. But this can be done in a separate PR.
Collaborator
Author
|
Thanks for the quick review! :D There is definitely some more global cleanup to do too, but I wanted to make sure this code was really supposed to be dead. I agree with getting rid of |
sjakobi
approved these changes
Aug 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing this code has no impact on the output (try accepting before and after the commit). Offhand, it doesn't seem to impact any of the docs for libraries bundled with GHC either. We should either: