Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Comments

Convert GADTs properly#913

Merged
sjakobi merged 1 commit intohaskell:wip/hi-haddockfrom
harpocrates:convert-gadts
Aug 21, 2018
Merged

Convert GADTs properly#913
sjakobi merged 1 commit intohaskell:wip/hi-haddockfrom
harpocrates:convert-gadts

Conversation

@harpocrates
Copy link
Collaborator

@harpocrates harpocrates commented Aug 21, 2018

This does two things:

  1. makes sure that synifyTyCon always produces GADTs from type constructors that originally came from GADTs
  2. removes foralls on GADT constructors

@harpocrates harpocrates requested a review from sjakobi August 21, 2018 16:12
@harpocrates
Copy link
Collaborator Author

harpocrates commented Aug 21, 2018

The second of these points is somewhat arbitrary, but tends to be much nicer. Look at the before and after:

screen shot 2018-08-21 at 9 11 18 am screen shot 2018-08-21 at 9 11 24 am

sjakobi
sjakobi approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! :)

Thx Alec!

@sjakobi sjakobi merged commit a53c131 into haskell:wip/hi-haddock Aug 21, 2018
@harpocrates harpocrates deleted the convert-gadts branch October 16, 2018 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sjakobi sjakobi sjakobi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harpocrates @sjakobi