Skip to content

Remove cpp from monadcont - #183

Merged
sjshuck merged 4 commits into
haskell:masterfrom
sjshuck:remove-cpp-from-monadcont
Jun 8, 2026
Merged

Remove cpp from monadcont#183
sjshuck merged 4 commits into
haskell:masterfrom
sjshuck:remove-cpp-from-monadcont

Conversation

@sjshuck

@sjshuck sjshuck commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@sjshuck
sjshuck requested a review from L0neGamer June 8, 2026 10:19
The kind signature does not work in MHS, and it isn't necessary in GHC,
so delete it. Test for the latter.
@sjshuck
sjshuck force-pushed the remove-cpp-from-monadcont branch from 06bbcef to 120e91d Compare June 8, 2026 10:20

@L0neGamer L0neGamer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see that we don't need the kind signature, and I appreciate the test assertion.

I can't see that the CI has run, can you verify that it is meant to?

EDIT: I was too fast, it's going now.

Kinda crazy that there are no tests here...

@L0neGamer
L0neGamer self-requested a review June 8, 2026 10:24
@sjshuck
sjshuck merged commit 22fdb9e into haskell:master Jun 8, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants